Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed READ_ACTIONS required by TermsAggregationEvaluator #4582

Merged
merged 2 commits into from
Jul 29, 2024
Merged

Fixed READ_ACTIONS required by TermsAggregationEvaluator #4582

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
94c756f
Fixed READ_ACTIONS required by TermsAggregationEvaluator
nibix Jul 19, 2024
57bd4f3
Replaced hard-coded action names by constants from core
nibix Jul 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 10 additions & 7 deletions src/main/java/org/opensearch/security/privileges/TermsAggregationEvaluator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,11 @@
import org.apache.logging.log4j.Logger;

import org.opensearch.action.ActionRequest;
import org.opensearch.action.fieldcaps.FieldCapabilitiesAction;
import org.opensearch.action.get.GetAction;
import org.opensearch.action.get.MultiGetAction;
import org.opensearch.action.search.MultiSearchAction;
import org.opensearch.action.search.SearchAction;
import org.opensearch.action.search.SearchRequest;
import org.opensearch.cluster.metadata.IndexNameExpressionResolver;
import org.opensearch.cluster.service.ClusterService;
Expand All @@ -49,13 +54,11 @@ public class TermsAggregationEvaluator {
protected final Logger log = LogManager.getLogger(this.getClass());

private static final String[] READ_ACTIONS = new String[] {
"indices:data/read/msearch",
"indices:data/read/mget",
"indices:data/read/get",
"indices:data/read/search",
"indices:data/read/field_caps*"
DarshitChanpura marked this conversation as resolved.
Show resolved Hide resolved
// "indices:admin/mappings/fields/get*"
};
MultiSearchAction.NAME,
MultiGetAction.NAME,
GetAction.NAME,
SearchAction.NAME,
FieldCapabilitiesAction.NAME };

private static final QueryBuilder NONE_QUERY = new MatchNoneQueryBuilder();

Expand Down
Loading