-
Notifications
You must be signed in to change notification settings - Fork 273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix env var password hashing for PBKDF2 #4773
Fix env var password hashing for PBKDF2 #4773
Conversation
Signed-off-by: Terry Quigley <[email protected]>
Signed-off-by: Terry Quigley <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4773 +/- ##
==========================================
+ Coverage 67.98% 67.99% +0.01%
==========================================
Files 310 310
Lines 20924 20925 +1
Branches 3318 3319 +1
==========================================
+ Hits 14225 14228 +3
+ Misses 4951 4947 -4
- Partials 1748 1750 +2
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Signed-off-by: Terry Quigley <[email protected]> (cherry picked from commit 199662e) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@cwperks @willyborankin @derek-ho Thanks for the questions and approvals. Much appreciated! |
Description
Category (Bug fix)
Passwords provided as environment variables are always hashed using BCrypt even when configured to use something else. Authentication fails when using PBKDF2 .
Issues Resolved
Resolves #4771
Testing
Initially found testing on a personal cluster. Confirmed fix works.
Included new test for PBKDF2 with PR.
Run Bulk Integration Tests.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.