Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Merge feature/pit branch to main #2939

Open
wants to merge 1 commit into
base: 2.x
Choose a base branch
from

Commits on Aug 15, 2024

  1. Merge feature/pit branch to main (#2936)

    * Add pit for join queries (#2703)
    
    * Add search after for join
    
    Signed-off-by: Rupal Mahajan <[email protected]>
    
    * Enable search after by default
    
    Signed-off-by: Rupal Mahajan <[email protected]>
    
    * Add pit
    
    Signed-off-by: Rupal Mahajan <[email protected]>
    
    * nit
    
    Signed-off-by: Rupal Mahajan <[email protected]>
    
    * Fix tests
    
    Signed-off-by: Rupal Mahajan <[email protected]>
    
    * ignore joinWithGeoIntersectNL
    
    Signed-off-by: Rupal Mahajan <[email protected]>
    
    * Rerun CI with scroll
    
    Signed-off-by: Rupal Mahajan <[email protected]>
    
    * Remove unused code and retrigger CI with search_after true
    
    Signed-off-by: Rupal Mahajan <[email protected]>
    
    * Address comments
    
    Signed-off-by: Rupal Mahajan <[email protected]>
    
    * Remove unused code change
    
    Signed-off-by: Rupal Mahajan <[email protected]>
    
    * Update pit keep alive time with SQL_CURSOR_KEEP_ALIVE
    
    Signed-off-by: Rupal Mahajan <[email protected]>
    
    * Fix scroll condition
    
    Signed-off-by: Rupal Mahajan <[email protected]>
    
    * nit
    
    Signed-off-by: Rupal Mahajan <[email protected]>
    
    * Add pit before query execution
    
    Signed-off-by: Rupal Mahajan <[email protected]>
    
    * nit
    
    Signed-off-by: Rupal Mahajan <[email protected]>
    
    * Move pit from join request builder to executor
    
    Signed-off-by: Rupal Mahajan <[email protected]>
    
    * Remove unused methods
    
    Signed-off-by: Rupal Mahajan <[email protected]>
    
    * Add pit in parent class's run()
    
    Signed-off-by: Rupal Mahajan <[email protected]>
    
    * Add comment for fetching subsequent result in NestedLoopsElasticExecutor
    
    Signed-off-by: Rupal Mahajan <[email protected]>
    
    * Update comment
    
    Signed-off-by: Rupal Mahajan <[email protected]>
    
    * Add javadoc for pit handler
    
    Signed-off-by: Rupal Mahajan <[email protected]>
    
    * Add pit interface
    
    Signed-off-by: Rupal Mahajan <[email protected]>
    
    * Add pit handler unit test
    
    Signed-off-by: Rupal Mahajan <[email protected]>
    
    * Fix failed unit test CI
    
    Signed-off-by: Rupal Mahajan <[email protected]>
    
    * Fix spotless error
    
    Signed-off-by: Rupal Mahajan <[email protected]>
    
    * Rename pit class and add logs
    
    Signed-off-by: Rupal Mahajan <[email protected]>
    
    * Fix pit delete unit test
    
    Signed-off-by: Rupal Mahajan <[email protected]>
    
    ---------
    
    Signed-off-by: Rupal Mahajan <[email protected]>
    
    * Add pit for multi query (#2753)
    
    * Add search after for join
    
    Signed-off-by: Rupal Mahajan <[email protected]>
    
    * Enable search after by default
    
    Signed-off-by: Rupal Mahajan <[email protected]>
    
    * Add pit
    
    Signed-off-by: Rupal Mahajan <[email protected]>
    
    * nit
    
    Signed-off-by: Rupal Mahajan <[email protected]>
    
    * Fix tests
    
    Signed-off-by: Rupal Mahajan <[email protected]>
    
    * ignore joinWithGeoIntersectNL
    
    Signed-off-by: Rupal Mahajan <[email protected]>
    
    * Rerun CI with scroll
    
    Signed-off-by: Rupal Mahajan <[email protected]>
    
    * draft
    
    Signed-off-by: Rupal Mahajan <[email protected]>
    
    * Remove unused code and retrigger CI with search_after true
    
    Signed-off-by: Rupal Mahajan <[email protected]>
    
    * Address comments
    
    Signed-off-by: Rupal Mahajan <[email protected]>
    
    * Remove unused code change
    
    Signed-off-by: Rupal Mahajan <[email protected]>
    
    * Update pit keep alive time with SQL_CURSOR_KEEP_ALIVE
    
    Signed-off-by: Rupal Mahajan <[email protected]>
    
    * Fix scroll condition
    
    Signed-off-by: Rupal Mahajan <[email protected]>
    
    * nit
    
    Signed-off-by: Rupal Mahajan <[email protected]>
    
    * Add pit before query execution
    
    Signed-off-by: Rupal Mahajan <[email protected]>
    
    * Refactor get response with pit method
    
    Signed-off-by: Rupal Mahajan <[email protected]>
    
    * Update remaining scroll search calls
    
    Signed-off-by: Rupal Mahajan <[email protected]>
    
    * Fix integ test failures
    
    Signed-off-by: Rupal Mahajan <[email protected]>
    
    * nit
    
    Signed-off-by: Rupal Mahajan <[email protected]>
    
    * Move pit from join request builder to executor
    
    Signed-off-by: Rupal Mahajan <[email protected]>
    
    * Remove unused methods
    
    Signed-off-by: Rupal Mahajan <[email protected]>
    
    * Move pit from request to executor
    
    Signed-off-by: Rupal Mahajan <[email protected]>
    
    * Fix pit.delete call missed while merge
    
    Signed-off-by: Rupal Mahajan <[email protected]>
    
    * Move getResponseWithHits method to util class
    
    Signed-off-by: Rupal Mahajan <[email protected]>
    
    * add try catch for create delete pit in minus executor
    
    Signed-off-by: Rupal Mahajan <[email protected]>
    
    * move all common fields to ElasticHitsExecutor
    
    Signed-off-by: Rupal Mahajan <[email protected]>
    
    * add javadoc for ElasticHitsExecutor
    
    Signed-off-by: Rupal Mahajan <[email protected]>
    
    * Add missing javadoc
    
    Signed-off-by: Rupal Mahajan <[email protected]>
    
    * Forcing an empty commit as last commit is stuck processing updates
    
    Signed-off-by: Rupal Mahajan <[email protected]>
    
    ---------
    
    Signed-off-by: Rupal Mahajan <[email protected]>
    
    ---------
    
    Signed-off-by: Rupal Mahajan <[email protected]>
    Signed-off-by: Manasvini B S <[email protected]>
    Co-authored-by: Rupal Mahajan <[email protected]>
    (cherry picked from commit 7815c96)
    Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
    github-actions[bot] and rupal-bq committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    4ec6d8a View commit details
    Browse the repository at this point in the history