Throw exception for RECOVER INDEX JOB query #2988
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tomoyuki Morita <[email protected]>
ykmr1224
requested review from
ps48,
kavithacm,
derek-ho,
joshuali925,
dai-chen,
YANG-DB,
rupal-bq,
mengweieric,
vamsi-amazon,
Swiddis,
penghuo,
seankao-az,
MaxKsyunz,
Yury-Fridlyand,
anirudha,
forestmvey,
acarbonetto,
GumpacG and
LantaoJin
as code owners
ykmr1224
added
backport 2.x
maintenance
seankao-az
approved these changes
Sep 9, 2024
dai-chen
approved these changes
Sep 9, 2024
| @@ -119,6 +119,9 @@ private AsyncQueryHandler getQueryHandlerForFlintExtensionQuery( | |||
| } else if (IndexQueryActionType.REFRESH.equals(indexQueryDetails.getIndexQueryActionType())) { | |||
| // Manual refresh should be handled by batch handler | |||
| return queryHandlerFactory.getRefreshQueryHandler(dispatchQueryRequest.getAccountId()); | |||
| } else if (IndexQueryActionType.RECOVER.equals(indexQueryDetails.getIndexQueryActionType())) { | |||
| // RECOVER INDEX JOB should not be executed from async-query-core | |||
| throw new IllegalArgumentException("RECOVER INDEX JOB is not allowed."); | |||
There was a problem hiding this comment.
throw unsupported operation exception?
There was a problem hiding this comment.
I checked other codes and IllegalArgumentException tend to be used when user specified something unsupported in the parameters. And UnsupportedOperationException tend to be used for when the operation (like create, delete, etc.) itself is not supported. I see mixed cases, though...
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Sep 9, 2024
Signed-off-by: Tomoyuki Morita <[email protected]> (cherry picked from commit 2c878fb) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
ykmr1224
pushed a commit
that referenced
this pull request
Sep 9, 2024
(cherry picked from commit 2c878fb) Signed-off-by: Tomoyuki Morita <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issues
n/a
Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.