Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch 2.0 branch workbench to 2.0.0.0 #596

Conversation

peterzhuamazon
Copy link
Member

Description

Switch 2.0 branch workbench to 2.0.0.0

Issues Resolved

Part of opensearch-project/opensearch-build#2086

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@peterzhuamazon peterzhuamazon requested a review from a team as a code owner May 4, 2022 18:57
@peterzhuamazon peterzhuamazon self-assigned this May 4, 2022
@peterzhuamazon peterzhuamazon changed the base branch from 2.0 to main May 4, 2022 19:01
@codecov-commenter
Copy link

Codecov Report

Merging #596 (f70dbee) into main (a7d4395) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main     #596   +/-   ##
=========================================
  Coverage     94.59%   94.59%           
  Complexity     2743     2743           
=========================================
  Files           276      276           
  Lines          7455     7455           
  Branches        551      551           
=========================================
  Hits           7052     7052           
  Misses          349      349           
  Partials         54       54           
Flag Coverage Δ
query-workbench 62.76% <ø> (ø)
sql-engine 97.67% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a7d4395...f70dbee. Read the comment docs.

@joshuali925
Copy link
Member

also remove rc1 here https://github.com/peterzhuamazon/sql/blob/opensearch-2.0.0-ga-fix/workbench/opensearch_dashboards.json#L3?

{
  "id": "queryWorkbenchDashboards",
  "version": "2.0.0.0-rc1",
  "opensearchDashboardsVersion": "2.0.0",

@peterzhuamazon
Copy link
Member Author

Since I have opened an issue for your team #597.
I think I will leave you guys handle it 😄 .

This PR was created under the assumption that only a few dashboards plugin has the rc1.

Thanks.

@peterzhuamazon peterzhuamazon deleted the opensearch-2.0.0-ga-fix branch May 5, 2022 02:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants