[WIP] Optimized Dockerfile for small image size #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@aireilly PTAL |
|
@gaurav-nelson I'm honestly assuming https://github.com/openshift-cs/docs-builder/blob/main/asciibinder/asciibinder.Dockerfile would benefit from a similar exercise. I'm not seeing anything obvious here that would impact the reliability...and having a smaller image is always a win! Assuming @aireilly is onboard (since he did the last edits), then I'm ➕1️⃣ on a merge |
|
Thank you @wgordon17 I'll check that one as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some optimizations for the image.
Down from 1.68 GB to just 394 MB. Around 75% smaller!🤦🏼♂️ Compared with the wrong image. Down from 412 MB to 394 MB.I tested locally and worked fine for me on Intel Mac. Need more testing before we can merge.