Address return consistency #355
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebrandon1
requested review from
trewest,
achuzhoy,
kononovn,
wabouhamad and
cdvultur
as code owners
sebrandon1
force-pushed
the
newbuilder_validation
branch
4 times, most recently
from
33e7b4b to
701df76
Compare
sebrandon1
force-pushed
the
newbuilder_validation
branch
10 times, most recently
from
4b15168 to
d4a29cd
Compare
sebrandon1
force-pushed
the
newbuilder_validation
branch
4 times, most recently
from
4a38ea2 to
b26e659
Compare
sebrandon1
force-pushed
the
newbuilder_validation
branch
5 times, most recently
from
3817184 to
010f891
Compare
This was referenced Jan 3, 2025
sebrandon1
force-pushed
the
newbuilder_validation
branch
2 times, most recently
from
b00264d to
38119dc
Compare
sebrandon1
force-pushed
the
newbuilder_validation
branch
4 times, most recently
from
a179df8 to
a3d8f9b
Compare
sebrandon1
force-pushed
the
newbuilder_validation
branch
3 times, most recently
from
0d5077b to
4c59a60
Compare
kononovn
pushed a commit
that referenced
this pull request
Jan 22, 2025
* Added unit tests for the Restore Get, Exists, Create, Update, and Delete methods. * Updated returns to be more in line with #355. * Added coverage to NewRestoreBuilder and PullRestore functions for when the apiClient is nil.
sebrandon1
force-pushed
the
newbuilder_validation
branch
2 times, most recently
from
8287c03 to
44bcda3
Compare
add argocd applications updates
sebrandon1
force-pushed
the
newbuilder_validation
branch
from
44bcda3 to
9b16410
Compare
|
Closing as all of the issues with returns have been addressed in other PRs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I went through the entire codebase and addressed inconsistencies with
returnstatements to make everything the "same".Now we can expect: