build: buildinfo: move buildinfo struct in internal api #1111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ffromani The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
ffromani
force-pushed
the
staticize-versions
branch
from
e28a1f4 to
c37bd5f
Compare
ffromani
added
cherry-pick-candidate
ffromani
force-pushed
the
staticize-versions
branch
from
c37bd5f to
02d31b4
Compare
openshift-ci
bot
added
the
approved
use the buildinfo.json data for `pkg/version` instead of injecting the values at link time. This simplifies the builds and enables better introspection capabilities. Signed-off-by: Francesco Romani <[email protected]>
ffromani
force-pushed
the
staticize-versions
branch
from
02d31b4 to
34bfa75
Compare
|
/retest |
|
/lgtm |
|
/cherry-pick release-4.18 |
ffromani
added
the
cherry-pick-approved
|
@ffromani: new pull request created: #1125 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
use the buildinfo.json data for
pkg/versioninstead of injecting the values at link time.This simplifies the builds and enables better introspection capabilities.