Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCPBUGS-47649:vendor: bump golang.org/x/net -> v0.33.0 #1127

Merged
merged 1 commit into from
Dec 24, 2024
Merged

OCPBUGS-47649:vendor: bump golang.org/x/net -> v0.33.0 #1127

merged 1 commit into from
Dec 24, 2024

Conversation

Tal-or
Copy link
Collaborator

@Tal-or Tal-or commented Dec 22, 2024

This bump intended to fix:
https://osv.dev/vulnerability/GO-2024-3333

@openshift-ci openshift-ci bot requested review from ffromani and shajmakh December 22, 2024 15:00
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Dec 22, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Tal-or

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 22, 2024
yanirq
yanirq reviewed Dec 24, 2024
View reviewed changes
go.mod
@@ -24,12 +24,13 @@ require (
github.com/openshift/machine-config-operator v0.0.1-0.20230724174830-7b54f1dcce4e
github.com/sergi/go-diff v1.1.0
github.com/stretchr/testify v1.9.0
golang.org/x/sync v0.8.0
golang.org/x/sync v0.10.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this a direct artifact from the bump?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All the changes here are derived by the bump of golang.org/x/net -> v0.33.0
and calling go mod tidy && go mod vendor after that

yanirq
yanirq reviewed Dec 24, 2024
View reviewed changes
go.mod
k8s.io/api v0.31.2
k8s.io/apiextensions-apiserver v0.31.2
k8s.io/apimachinery v0.31.2
k8s.io/client-go v0.31.2
k8s.io/code-generator v0.31.2
k8s.io/klog v1.0.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this a direct artifact from the bump?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

indeed

@yanirq
Copy link
Member

yanirq commented Dec 24, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 24, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 3d606e1 into openshift-kni:main Dec 24, 2024
15 checks passed
@Tal-or
Copy link
Collaborator Author

Tal-or commented Dec 25, 2024

/cherry-pick release-4.18

@openshift-cherrypick-robot
Copy link

@Tal-or: new pull request created: #1128

In response to this:

/cherry-pick release-4.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Dec 25, 2024
Merged
@Tal-or Tal-or changed the title vendor: bump golang.org/x/net -> v0.33.0 OCPBUGS-47649:vendor: bump golang.org/x/net -> v0.33.0 Dec 25, 2024
@openshift-ci-robot
Copy link

@Tal-or: Jira Issue OCPBUGS-47649: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-47649 has been moved to the MODIFIED state.

In response to this:

This bump intended to fix:
https://osv.dev/vulnerability/GO-2024-3333

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@Tal-or Tal-or mentioned this pull request Jan 1, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yanirq yanirq yanirq left review comments

@ffromani ffromani Awaiting requested review from ffromani

@shajmakh shajmakh Awaiting requested review from shajmakh

Assignees

@yanirq yanirq

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Tal-or @yanirq @openshift-cherrypick-robot @openshift-ci-robot