Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add examples of usage with multiple mcps #69

Merged
merged 1 commit into from
Jan 9, 2025

Conversation

jnunyez
Copy link
Contributor

@jnunyez jnunyez commented Dec 3, 2024

Adding PolicyGen with unpause and setting maxUnavailable in a unique harmonized example.
Created new MCP worker-3. Update kustomize.

@openshift-ci openshift-ci bot requested review from fedepaol and ffromani December 3, 2024 09:32
@jnunyez jnunyez force-pushed the CNF-11808 branch 3 times, most recently from 320d1dd to c38703b Compare December 11, 2024 19:38
placement:
clusterSelectors:
common: "core"
finish-version-4.18: ""
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar to core-overlay and core-baseline I think we want this to be version: "4.18". If we want to bind only during initial cluster install we can add an exclusion for ztp-done.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed. Note that core-upgrade has upgrade-version-4-18: ""

- type: Updated
status: "True"
- type: Updating
status: "False"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
status: "False"
status: "False"

From the lint check there is an extra space at the end of this line.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

Copy link
Contributor

@imiller0 imiller0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 9, 2025
Copy link

openshift-ci bot commented Jan 9, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: imiller0, jnunyez

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 9, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit 5ff21f0 into openshift-kni:main Jan 9, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants