-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add examples of usage with multiple mcps #69
Conversation
320d1dd
to
c38703b
Compare
placement: | ||
clusterSelectors: | ||
common: "core" | ||
finish-version-4.18: "" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similar to core-overlay and core-baseline I think we want this to be version: "4.18"
. If we want to bind only during initial cluster install we can add an exclusion for ztp-done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed. Note that core-upgrade has upgrade-version-4-18: ""
- type: Updated | ||
status: "True" | ||
- type: Updating | ||
status: "False" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
status: "False" | |
status: "False" |
From the lint check there is an extra space at the end of this line.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: imiller0, jnunyez The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Adding PolicyGen with unpause and setting maxUnavailable in a unique harmonized example.
Created new MCP worker-3. Update kustomize.