Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Synchronize telco-core reference-crs and reference-crs-kube-compare #73

Merged
merged 1 commit into from
Jan 9, 2025

Conversation

lack
Copy link
Member

@lack lack commented Dec 9, 2024

This change also:

  • Converts the cluster-compare reference to API v2
  • Adds references to the downstream docs using the new "description" facility

Signed-off-by: Jim Ramsay [email protected]

@openshift-ci openshift-ci bot requested review from fedepaol and SchSeba December 9, 2024 20:33
This change also:
- Converts the cluster-compare reference to API v2
- Adds references to the downstream docs using the new "description" facility

Signed-off-by: Jim Ramsay <[email protected]>
@@ -7,7 +7,7 @@ metadata:
name: odf-operator
namespace: openshift-storage
spec:
channel: "stable-4.14"
channel: "stable-4.18"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not 4.19?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Multiple places where 4.18 is mentioned, better do that in a separate commit once 4.18 is GAd.

Copy link
Member

@MarSik MarSik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 9, 2025
Copy link

openshift-ci bot commented Jan 9, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lack, MarSik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 9, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit ca04b4d into openshift-kni:main Jan 9, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants