CNF-16121: Backport cluster-compare templates to 4.17 #79
Conversation
|
@lack: This pull request references CNF-16121 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
lack
force-pushed
the
cluster-compare-backport-4.17
branch
3 times, most recently
from
6d5993d to
40cc15d
Compare
| ci-validate: check-reference | ||
|
|
||
| # Basic lint checking | ||
| lintCheck: |
There was a problem hiding this comment.
In 4.18 we call this from ci-validate, right? is there a reason the 4.17 does not?
There was a problem hiding this comment.
Correct. In 4.17 we have the infrastructure to call it, but not the changes @imiller0 made to make the yaml files complaint. So enabling this, without also backporting those changes, would make the CI fail.
There was a problem hiding this comment.
Added a comment to explain this :)
Signed-off-by: Jim Ramsay <[email protected]>
lack
force-pushed
the
cluster-compare-backport-4.17
branch
from
40cc15d to
69e07c9
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lack, MarSik The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
openshift-merge-bot
bot
merged commit 78ccfed
into
openshift-kni:release-4.17
Signed-off-by: Jim Ramsay [email protected]