API-1835: separate apply-configuration-live from apply-configuration #718
Conversation
| // TODO MOM this call here is the one that fails. Using the return value of ApplyDeployment to make decisions doesn't work in a MOM world. | ||
| // TODO MOM workload.NewController needs to (somehow) use the data read *after* this write, without using data *in* this write. | ||
| // TODO MOM this may be possible by storing a hash of the desired content. If the hash of the desired content matches | ||
| // TODO MOM then there is no new deployment required. This would not prevent rapid writes to fields we aren't controlling. | ||
| // TODO MOM perhaps we actually need to find a way to request MOM inject a generation after a write? It is an operator standard. |
There was a problem hiding this comment.
This is sticky. The hash probably won't work. Making MOM aware of writing workload generation may be the only way to achieve parity.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: deads2k The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
deads2k
force-pushed
the
apply-07-runone
branch
from
49835db to
30dea78
Compare
deads2k
changed the title
openshift-ci-robot
added
the
jira/valid-reference
|
@deads2k: This pull request references API-1835 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target the "4.18.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-merge-robot
added
the
needs-rebase
deads2k
force-pushed
the
apply-07-runone
branch
from
30dea78 to
252822f
Compare
openshift-merge-robot
removed
the
needs-rebase
|
@deads2k: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
openshift-merge-robot
added
the
needs-rebase
|
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
This does the initial split of live functions (things that must reach out to external services and may or may not work on hypershift due to networking configuration), from things that don't have that problem.
Builds on top of some library-go and multi-operator-manager PRs that need to land.