Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-45903: [release-4.18] PPC: correct EnableHardwareTuning flag value #1270

Merged
merged 1 commit into from
Jan 7, 2025

Conversation

shajmakh
Copy link
Contributor

By mistake this was overridden to always true in this PR: #1236 Correct this by setting the value equal to the passed value from the parsed data.

Signed-off-by: Shereen Haj [email protected]
(cherry picked from commit 827db75)

By mistake this was overridden to always `true` in this PR: openshift#1236
Correct this by setting the value equal to the passed value from the
parsed data.

Signed-off-by: Shereen Haj <[email protected]>
(cherry picked from commit 827db75)
@openshift-ci openshift-ci bot requested review from ffromani and MarSik December 31, 2024 00:16
@shajmakh shajmakh changed the title PPC: correct EnableHardwareTuning flag value [release-4.18] PPC: correct EnableHardwareTuning flag value Dec 31, 2024
Copy link
Contributor

@swatisehgal swatisehgal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

/retest-required

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 3, 2025
@swatisehgal
Copy link
Contributor

/test okd-scos-e2e-aws-ovn

@shajmakh
Copy link
Contributor Author

shajmakh commented Jan 6, 2025

/test e2e-hypershift

@shajmakh
Copy link
Contributor Author

shajmakh commented Jan 6, 2025

/cc @yanirq

@openshift-ci openshift-ci bot requested a review from yanirq January 6, 2025 09:07
@yanirq
Copy link
Contributor

yanirq commented Jan 6, 2025

/approve
/label backport-risk-assessed

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Jan 6, 2025
Copy link
Contributor

openshift-ci bot commented Jan 6, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: shajmakh, yanirq

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 6, 2025
@yanirq
Copy link
Contributor

yanirq commented Jan 6, 2025

@shajmakh if you are going to cherry pick this any further it will require a bug.

@shajmakh shajmakh changed the title [release-4.18] PPC: correct EnableHardwareTuning flag value OCPBUGS-45903: [release-4.18] PPC: correct EnableHardwareTuning flag value Jan 6, 2025
@openshift-ci-robot openshift-ci-robot added jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Jan 6, 2025
@openshift-ci-robot
Copy link
Contributor

@shajmakh: This pull request references Jira Issue OCPBUGS-45903, which is valid.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.18.0) matches configured target version for branch (4.18.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note text is set and does not match the template
  • dependent bug Jira Issue OCPBUGS-44372 is in the state Verified, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
  • dependent Jira Issue OCPBUGS-44372 targets the "4.19.0" version, which is one of the valid target versions: 4.19.0
  • bug has dependents

Requesting review from QA contact:
/cc @mrniranjan

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

By mistake this was overridden to always true in this PR: #1236 Correct this by setting the value equal to the passed value from the parsed data.

Signed-off-by: Shereen Haj [email protected]
(cherry picked from commit 827db75)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested a review from mrniranjan January 6, 2025 09:33
@shajmakh
Copy link
Contributor Author

shajmakh commented Jan 6, 2025

/cc @mrniranjan

Copy link
Contributor

openshift-ci bot commented Jan 6, 2025

@shajmakh: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-scos-e2e-aws-ovn fc95cb0 link false /test okd-scos-e2e-aws-ovn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@shajmakh
Copy link
Contributor Author

shajmakh commented Jan 6, 2025

/test e2e-hypershift

@mrniranjan
Copy link
Contributor

/label cherry-pick-approved

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Jan 7, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit cb57a4d into openshift:release-4.18 Jan 7, 2025
17 of 18 checks passed
@openshift-ci-robot
Copy link
Contributor

@shajmakh: Jira Issue OCPBUGS-45903: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-45903 has been moved to the MODIFIED state.

In response to this:

By mistake this was overridden to always true in this PR: #1236 Correct this by setting the value equal to the passed value from the parsed data.

Signed-off-by: Shereen Haj [email protected]
(cherry picked from commit 827db75)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants