-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCPBUGS-45903: [release-4.18] PPC: correct EnableHardwareTuning flag value #1270
OCPBUGS-45903: [release-4.18] PPC: correct EnableHardwareTuning flag value #1270
Conversation
By mistake this was overridden to always `true` in this PR: openshift#1236 Correct this by setting the value equal to the passed value from the parsed data. Signed-off-by: Shereen Haj <[email protected]> (cherry picked from commit 827db75)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/retest-required
/test okd-scos-e2e-aws-ovn |
/test e2e-hypershift |
/cc @yanirq |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: shajmakh, yanirq The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@shajmakh if you are going to cherry pick this any further it will require a bug. |
@shajmakh: This pull request references Jira Issue OCPBUGS-45903, which is valid. 7 validation(s) were run on this bug
Requesting review from QA contact: The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/cc @mrniranjan |
@shajmakh: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
/test e2e-hypershift |
/label cherry-pick-approved |
cb57a4d
into
openshift:release-4.18
@shajmakh: Jira Issue OCPBUGS-45903: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-45903 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
By mistake this was overridden to always
true
in this PR: #1236 Correct this by setting the value equal to the passed value from the parsed data.Signed-off-by: Shereen Haj [email protected]
(cherry picked from commit 827db75)