Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GITOPS-3433: get ready for cypress upgrade #13239

Merged

Conversation

ciiay
Copy link
Contributor

@ciiay ciiay commented Oct 12, 2023

This is for the cypress upgrade. This can't be merged in until rebase master after #13070 PR goes in.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 12, 2023
@openshift-ci openshift-ci bot added component/dev-console Related to dev-console component/gitops Related to gitops-plugin component/olm Related to OLM component/topology Related to topology kind/cypress Related to Cypress e2e integration testing labels Oct 12, 2023
@rhamilto
Copy link
Member

@ciiay, please rebase to resolve conflicts. Any word from QE about the re-enablement of the Cucumber tests?

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 16, 2023
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 16, 2023
@ciiay
Copy link
Contributor Author

ciiay commented Oct 16, 2023

@rhamilto Conflicts resolved. Our QE team is still working on it. Will update here asap.

@rhamilto
Copy link
Member

/lgtm

/label tide/merge-method-squash

@openshift-ci openshift-ci bot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Oct 16, 2023
@rhamilto rhamilto changed the title [WIP] Gitops 3433 get ready for cypress upgrade GITOPS-3433 get ready for cypress upgrade Oct 16, 2023
@rhamilto rhamilto changed the title GITOPS-3433 get ready for cypress upgrade GITOPS-3433: get ready for cypress upgrade Oct 16, 2023
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Oct 16, 2023
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Oct 16, 2023

@ciiay: This pull request references GITOPS-3433 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but no target version was set.

In response to this:

This is for the cypress upgrade. This can't be merged in until rebase master after #13070 PR goes in.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 16, 2023
@rhamilto
Copy link
Member

Work is tech debt and has no customer-facing impact.

/label docs-approved
/label px-approved
/label qe-approved

@openshift-ci openshift-ci bot added docs-approved Signifies that Docs has signed off on this PR px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR labels Oct 16, 2023
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Oct 16, 2023

@ciiay: This pull request references GITOPS-3433 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but no target version was set.

In response to this:

This is for the cypress upgrade. This can't be merged in until rebase master after #13070 PR goes in.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rhamilto
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 16, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 16, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ciiay, rhamilto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 16, 2023
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 6f9fc57 and 2 for PR HEAD 3723277 in total

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 17, 2023

@ciiay: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci openshift-ci bot merged commit b7629f5 into openshift:master Oct 17, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/dev-console Related to dev-console component/gitops Related to gitops-plugin component/olm Related to OLM component/topology Related to topology docs-approved Signifies that Docs has signed off on this PR jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. kind/cypress Related to Cypress e2e integration testing lgtm Indicates that a PR is ready to be merged. px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants