Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pin and pre-load images #1481

Merged
merged 20 commits into from
Nov 1, 2023
Merged

Pin and pre-load images #1481

merged 20 commits into from
Nov 1, 2023

Commits on Sep 21, 2023

  1. Pin and pre-load images 

    This patch adds an enhancement that describes a mechanism to pin and
pre-load container images.

Related: https://issues.redhat.com/browse/RFE-4482
Related: https://issues.redhat.com/browse/OTA-1001
Related: https://issues.redhat.com/browse/OTA-997
Related: openshift/machine-config-operator#3839
Related: openshift#1432

Signed-off-by: Juan Hernandez <[email protected]>
    @jhernand
    jhernand committed Sep 21, 2023
    Configuration menu
    Copy the full SHA
    8a07077 View commit details
    Browse the repository at this point in the history

Commits on Sep 25, 2023

  1. Add reviewers comments 

    This patch adds YAML comments explaining what is the reason to add
specific reviewers.

Signed-off-by: Juan Hernandez <[email protected]>
    @jhernand
    jhernand committed Sep 25, 2023
    Configuration menu
    Copy the full SHA
    da7d638 View commit details
    Browse the repository at this point in the history

Commits on Sep 26, 2023

  1. Orchestrating upgrades is a non-goal 

    This patch adds a paragraph to the non-goals section explaining that
orchestrating upgrades is not a goal of this enhancement.

Signed-off-by: Juan Hernandez <[email protected]>
    @jhernand
    jhernand committed Sep 26, 2023
    Configuration menu
    Copy the full SHA
    ee760a1 View commit details
    Browse the repository at this point in the history

Commits on Sep 28, 2023

  1. Add comment about upgrade time consistency 

    Signed-off-by: Juan Hernandez <[email protected]>
    @jhernand
    jhernand committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    433c28e View commit details
    Browse the repository at this point in the history

  2. Add @sinnykumari and @mrunalp as approvers 

    Signed-off-by: Juan Hernandez <[email protected]>
    @jhernand
    jhernand committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    8df4279 View commit details
    Browse the repository at this point in the history

Commits on Sep 29, 2023

  1. Pinned images shouldn't be wiped 

    Signed-off-by: Juan Hernandez <[email protected]>
    @jhernand
    jhernand committed Sep 29, 2023
    Configuration menu
    Copy the full SHA
    7d2bf33 View commit details
    Browse the repository at this point in the history

Commits on Oct 2, 2023

  1. Disk space exhaustion risk and mitigations 

    Signed-off-by: Juan Hernandez <[email protected]>
    @jhernand
    jhernand committed Oct 2, 2023
    Configuration menu
    Copy the full SHA
    fba408f View commit details
    Browse the repository at this point in the history

  2. Add PinnedImageSet object 

    This patch changes the enhacement adding a new `PinnedImageSet` object
instead of modifying the `ContainerRuntimeConfig` object.

Signed-off-by: Juan Hernandez <[email protected]>
    @jhernand
    jhernand committed Oct 2, 2023
    Configuration menu
    Copy the full SHA
    82fc4cf View commit details
    Browse the repository at this point in the history

  3. Fix lint issues 

    Signed-off-by: Juan Hernandez <[email protected]>
    @jhernand
    jhernand committed Oct 2, 2023
    Configuration menu
    Copy the full SHA
    0c6fe1d View commit details
    Browse the repository at this point in the history

Commits on Oct 6, 2023

  1. Move API PR to openshift/api 

    Signed-off-by: Juan Hernandez <[email protected]>
    @jhernand
    jhernand committed Oct 6, 2023
    Configuration menu
    Copy the full SHA
    54b515b View commit details
    Browse the repository at this point in the history

  2. Clarify that image wiping needs to be changed in CRI-O 

    Signed-off-by: Juan Hernandez <[email protected]>
    @jhernand
    jhernand committed Oct 6, 2023
    Configuration menu
    Copy the full SHA
    7946c21 View commit details
    Browse the repository at this point in the history

  3. Explain the new logic will be part of a new MCC sub-controller 

    Signed-off-by: Juan Hernandez <[email protected]>
    @jhernand
    jhernand committed Oct 6, 2023
    Configuration menu
    Copy the full SHA
    a9ff7e7 View commit details
    Browse the repository at this point in the history

Commits on Oct 9, 2023

  1. Use "custom resource" instead of "object" 

    This patch changes the document to use "custom resource" instead of
"object" to make clear that we will be adding a new `PinnedImageSet`
custom resource to the API.

Signed-off-by: Juan Hernandez <[email protected]>
    @jhernand
    jhernand committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    2ef880c View commit details
    Browse the repository at this point in the history

Commits on Oct 11, 2023

  1. CRI-O will need to reset pinned images on reload 

    Signed-off-by: Juan Hernandez <[email protected]>
    @jhernand
    jhernand committed Oct 11, 2023
    Configuration menu
    Copy the full SHA
    f379ab1 View commit details
    Browse the repository at this point in the history

Commits on Oct 13, 2023

  1. Fix name of worker PinnedImageSet 

    Signed-off-by: Juan Hernandez <[email protected]>
    @jhernand
    jhernand committed Oct 13, 2023
    Configuration menu
    Copy the full SHA
    a16ccec View commit details
    Browse the repository at this point in the history

Commits on Oct 16, 2023

  1. Add details about PinnedImageSetController sub controller 

    Signed-off-by: Juan Hernandez <[email protected]>
    @jhernand
    jhernand committed Oct 16, 2023
    Configuration menu
    Copy the full SHA
    25fc032 View commit details
    Browse the repository at this point in the history

Commits on Oct 18, 2023

  1. Check disk space before pulling images 

    Signed-off-by: Juan Hernandez <[email protected]>
    @jhernand
    jhernand committed Oct 18, 2023
    Configuration menu
    Copy the full SHA
    0f37ea0 View commit details
    Browse the repository at this point in the history

Commits on Oct 19, 2023

  1. Fix line lengths 

    Signed-off-by: Juan Hernandez <[email protected]>
    @jhernand
    jhernand committed Oct 19, 2023
    Configuration menu
    Copy the full SHA
    014d66c View commit details
    Browse the repository at this point in the history

  2. Clarify what pulls images 

    Signed-off-by: Juan Hernandez <[email protected]>
    @jhernand
    jhernand committed Oct 19, 2023
    Configuration menu
    Copy the full SHA
    a73e6c1 View commit details
    Browse the repository at this point in the history

  3. Consider using the new MCO state reporting mechanism 

    Signed-off-by: Juan Hernandez <[email protected]>
    @jhernand
    jhernand committed Oct 19, 2023
    Configuration menu
    Copy the full SHA
    ca63f06 View commit details
    Browse the repository at this point in the history