-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add SDK v4 compatibility layer. #149
Add SDK v4 compatibility layer. #149
Conversation
Can one of the admins verify this patch? |
Hi @Hyperkid123. Thanks for your PR. I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #149 +/- ##
==========================================
- Coverage 34.07% 33.84% -0.22%
==========================================
Files 30 30
Lines 458 461 +3
Branches 77 79 +2
==========================================
Hits 156 156
- Misses 278 281 +3
Partials 24 24
☔ View full report in Codecov by Sentry. |
@Hyperkid123: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Hyperkid123, karelhala The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This is change is required to enable a bridge between SDK 3 and 4 for hac apps.
requires: RedHatInsights/insights-chrome#2663
cc @karelhala