Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix slice delete issue #218

Merged
merged 4 commits into from
Nov 5, 2024
Merged

fix slice delete issue #218

merged 4 commits into from
Nov 5, 2024

Conversation

asm582
Copy link
Contributor

@asm582 asm582 commented Nov 3, 2024

On OpenShift SNO install slices were not deleted in some instances. The root cause of this issue is unknown as it is not reproducible on the KinD cluster; one theory is that multiple NVML init calls could cause non-determinism in slice discovery, and an issue is opened for such a use case in #225. This PR has improved logging when a slice is not found and retries when a slice is not found, but the config map for workload still exists in the system.

make test ,make lint, make test-e2e and daemonset shell script all pass locally.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 3, 2024
Copy link

openshift-ci bot commented Nov 3, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

Copy link

openshift-ci bot commented Nov 3, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: asm582

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 3, 2024
@asm582 asm582 marked this pull request as ready for review November 4, 2024 21:27
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 4, 2024
@openshift-ci openshift-ci bot requested review from kannon92 and mrunalp November 4, 2024 21:27
@asm582 asm582 requested review from harche and rphillips November 4, 2024 21:28
@asm582 asm582 changed the title fix timing issue fix slice delete issue Nov 4, 2024
Copy link

openshift-ci bot commented Nov 4, 2024

@asm582: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@empovit
Copy link
Contributor

empovit commented Nov 5, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 5, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 64a50f9 into main Nov 5, 2024
6 of 10 checks passed
@asm582 asm582 deleted the fix_timing branch November 5, 2024 16:18
cpmeadors pushed a commit to cpmeadors/instaslice-operator that referenced this pull request Nov 5, 2024
* fix timing issue

* fix lint

* retry if cm exists
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants