-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix slice delete issue #218
Conversation
Skipping CI for Draft Pull Request. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: asm582 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@asm582: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
/lgtm |
* fix timing issue * fix lint * retry if cm exists
On OpenShift SNO install slices were not deleted in some instances. The root cause of this issue is unknown as it is not reproducible on the KinD cluster; one theory is that multiple NVML init calls could cause non-determinism in slice discovery, and an issue is opened for such a use case in #225. This PR has improved logging when a slice is not found and retries when a slice is not found, but the config map for workload still exists in the system.
make test
,make lint
,make test-e2e
and daemonset shell script all pass locally.