Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MCO-1437: MCO-1476: MCO-1477: MCO-1284: Adapt MCO to OCL v1 API #4756

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

MCO-1437: MCO-1476: MCO-1477: MCO-1284: Adapt MCO to OCL v1 API #4756

wants to merge 7 commits into from

Conversation

djoshy
Copy link
Contributor

@djoshy djoshy commented Dec 13, 2024 •
edited
Loading

This PR does the following:

  • bumps client-go to capture OCL v1 API helpers
  • reconciles machine-os-builder and the operator to handle OCL v1 API
  • reconciles existing units/e2es to handle OCL v1 API
  • adds a global pull secret cloning mechanism since BaseImagePullSecret is optional in v1 API

How to test/verify:

  • TechPreview should be enabled
  • All existing units/e2es should pass
  • OCL workflows should be tested with v1 CRs(v1alpha1 CRDs will no longer work).

Note: This PR should be tested and merged along with openshift/api#2134

Clusterbot incantation:

launch openshift/machine-config-operator#4756,openshift/api#2134 techpreview

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Dec 13, 2024
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 13, 2024
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Dec 13, 2024 •
edited by openshift-ci bot
Loading

@djoshy: This pull request references MCO-1437 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

[DNM] Testing current state of v1 API

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Dec 13, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Dec 13, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: djoshy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 13, 2024
djoshy
djoshy commented Dec 13, 2024
View reviewed changes
pkg/operator/render_test.go Outdated Show resolved Hide resolved
@djoshy
Copy link
Contributor Author

djoshy commented Dec 18, 2024

/test unit

@djoshy
Copy link
Contributor Author

djoshy commented Dec 18, 2024

/test unit
/test verify

@djoshy
Copy link
Contributor Author

djoshy commented Dec 18, 2024

/test unit
/test verify

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 20, 2024
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 20, 2024
@djoshy
Copy link
Contributor Author

djoshy commented Jan 20, 2025

/testwith openshift/machine-config-operator/master/e2e-gcp-op-ocl openshift/api#2134

@djoshy
Copy link
Contributor Author

djoshy commented Jan 20, 2025 •
edited
Loading

/testwith openshift/machine-config-operator/master/e2e-gcp-op-ocl #4756 openshift/api#2134

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jan 20, 2025

@djoshy, testwith: Error processing request. ERROR:

could not determine job runs: invalid format for additional PR: github.com/https://github.com/openshift/api/pull/2134

@djoshy djoshy force-pushed the reconcile-ocl-api branch from 4cae72e to 7ff6f32 Compare January 21, 2025 14:23
@djoshy
Copy link
Contributor Author

djoshy commented Jan 21, 2025

Rebased to fix merge conflicts

@djoshy
Copy link
Contributor Author

djoshy commented Jan 21, 2025

/testwith openshift/machine-config-operator/master/e2e-gcp-op-ocl #4756 openshift/api#2134

@djoshy
Copy link
Contributor Author

djoshy commented Jan 21, 2025

/payload-with-prs 4.19 nightly blocking #4756 openshift/api#2134

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jan 21, 2025

@djoshy: it appears that you have attempted to use some version of the payload command, but your comment was incorrectly formatted and cannot be acted upon. See the docs for usage info.

@djoshy
Copy link
Contributor Author

djoshy commented Jan 21, 2025

/payload-with-prs 4.19 nightly blocking openshift/api#2134 #4756

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jan 21, 2025

@djoshy: it appears that you have attempted to use some version of the payload command, but your comment was incorrectly formatted and cannot be acted upon. See the docs for usage info.

@djoshy
Copy link
Contributor Author

djoshy commented Jan 21, 2025

/payload-with-prs 4.19 nightly blocking #4756 openshift/api#2134

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jan 21, 2025

@djoshy: trigger 14 job(s) of type blocking for the nightly release of OCP 4.19

  • periodic-ci-openshift-release-master-ci-4.19-e2e-aws-upgrade-ovn-single-node
  • periodic-ci-openshift-release-master-ci-4.19-e2e-aws-ovn-upgrade
  • periodic-ci-openshift-release-master-ci-4.19-e2e-azure-ovn-upgrade
  • periodic-ci-openshift-release-master-ci-4.19-upgrade-from-stable-4.18-e2e-gcp-ovn-rt-upgrade
  • periodic-ci-openshift-hypershift-release-4.19-periodics-e2e-aws-ovn-conformance
  • periodic-ci-openshift-release-master-nightly-4.19-e2e-aws-ovn-serial
  • periodic-ci-openshift-release-master-ci-4.19-e2e-aws-ovn-techpreview
  • periodic-ci-openshift-release-master-ci-4.19-e2e-aws-ovn-techpreview-serial
  • periodic-ci-openshift-release-master-nightly-4.19-fips-payload-scan
  • periodic-ci-openshift-release-master-nightly-4.19-e2e-metal-ipi-ovn-bm
  • periodic-ci-openshift-release-master-nightly-4.19-e2e-metal-ipi-ovn-ipv6
  • periodic-ci-openshift-microshift-release-4.19-periodics-e2e-aws-ovn-ocp-conformance
  • periodic-ci-openshift-microshift-release-4.19-periodics-e2e-aws-ovn-ocp-conformance-serial
  • periodic-ci-openshift-release-master-nightly-4.19-e2e-rosa-sts-ovn

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/1fdf84b0-d820-11ef-9611-b0f41fcfd78c-0

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jan 21, 2025

@djoshy: This PR was included in a payload test run from #4756
trigger 14 job(s) of type blocking for the nightly release of OCP 4.19

  • periodic-ci-openshift-release-master-ci-4.19-e2e-aws-upgrade-ovn-single-node
  • periodic-ci-openshift-release-master-ci-4.19-e2e-aws-ovn-upgrade
  • periodic-ci-openshift-release-master-ci-4.19-e2e-azure-ovn-upgrade
  • periodic-ci-openshift-release-master-ci-4.19-upgrade-from-stable-4.18-e2e-gcp-ovn-rt-upgrade
  • periodic-ci-openshift-hypershift-release-4.19-periodics-e2e-aws-ovn-conformance
  • periodic-ci-openshift-release-master-nightly-4.19-e2e-aws-ovn-serial
  • periodic-ci-openshift-release-master-ci-4.19-e2e-aws-ovn-techpreview
  • periodic-ci-openshift-release-master-ci-4.19-e2e-aws-ovn-techpreview-serial
  • periodic-ci-openshift-release-master-nightly-4.19-fips-payload-scan
  • periodic-ci-openshift-release-master-nightly-4.19-e2e-metal-ipi-ovn-bm
  • periodic-ci-openshift-release-master-nightly-4.19-e2e-metal-ipi-ovn-ipv6
  • periodic-ci-openshift-microshift-release-4.19-periodics-e2e-aws-ovn-ocp-conformance
  • periodic-ci-openshift-microshift-release-4.19-periodics-e2e-aws-ovn-ocp-conformance-serial
  • periodic-ci-openshift-release-master-nightly-4.19-e2e-rosa-sts-ovn

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/1fdf84b0-d820-11ef-9611-b0f41fcfd78c-0

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jan 21, 2025

@djoshy: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gcp-op-techpreview 7ff6f32 link false /test e2e-gcp-op-techpreview
ci/prow/e2e-azure-ovn-upgrade-out-of-change 7ff6f32 link false /test e2e-azure-ovn-upgrade-out-of-change
ci/prow/e2e-gcp-op-ocl 7ff6f32 link false /test e2e-gcp-op-ocl

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@djoshy
Copy link
Contributor Author

djoshy commented Jan 21, 2025

/testwith openshift/machine-config-operator/master/e2e-gcp-op-ocl openshift/api#2134

@sergiordlr
Copy link

Verified with openshift/api#2134 using IPI on AWS

All MCOQE e2e test cases passed.

/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Jan 22, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 22, 2025 •
edited by openshift-ci bot
Loading

@djoshy: This pull request references MCO-1437 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

This PR does the following:

  • bumps client-go to capture OCL v1 API helpers
  • reconciles machine-os-builder and the operator to handle OCL v1 API
  • reconciles existing units/e2es to handle OCL v1 API
  • adds a global pull secret cloning mechanism since BaseImagePullSecret is optional in v1 API

How to test/verify:

  • TechPreview should be enabled
  • All existing units/e2es should pass
  • OCL workflows should be tested with v1 CRs(v1alpha1 CRDs will no longer work).

Note: This PR should be tested and merged along with openshift/api#2134

Clusterbot incantation:

launch openshift/machine-config-operator#4756,openshift/api#2134 techpreview

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@djoshy
Copy link
Contributor Author

djoshy commented Jan 22, 2025

/payload-job-with-prs periodic-ci-openshift-release-master-ci-4.19-e2e-aws-ovn-upgrade #4756 openshift/api#2134

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jan 22, 2025

@djoshy: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-ci-4.19-e2e-aws-ovn-upgrade

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/c4f6d350-d8e7-11ef-828d-853e5124944e-0

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jan 22, 2025

@djoshy: This PR was included in a payload test run from #4756
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-ci-4.19-e2e-aws-ovn-upgrade

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/c4f6d350-d8e7-11ef-828d-853e5124944e-0

@djoshy
Copy link
Contributor Author

djoshy commented Jan 22, 2025

/payload-job-with-prs periodic-ci-openshift-hypershift-release-4.19-periodics-e2e-aws-ovn-conformance openshift/api#2134

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jan 22, 2025

@djoshy: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-hypershift-release-4.19-periodics-e2e-aws-ovn-conformance

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/11fa2340-d8e9-11ef-9d46-0307a541224a-0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@umohnani8 umohnani8 umohnani8 left review comments

@cheesesashimi cheesesashimi cheesesashimi left review comments

@RishabhSaini RishabhSaini Awaiting requested review from RishabhSaini

@yuqi-zhang yuqi-zhang Awaiting requested review from yuqi-zhang

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@djoshy @openshift-ci-robot @yuqi-zhang @sergiordlr @cheesesashimi @umohnani8 @openshift-merge-robot