OCPBUGS-45928: OCPBUGS-46531: crio: drop crun subcgroup #4774
Conversation
historically crun has run with a subcgroup to allow it to own the cgroup configuration of a container this is more idiomatic with systemd's single owner rule. The problem is the subcgroup means there is an extra cgroup for cadvisor to read metrics for, so moving to crun by default actually increases cpu usage. Dropping the subcgroup (with a new cri-o knob and this annotation) fixes this regression. This reverts commit 9e8ecf4, which was a revert of the original commit. CRI-O has now been fixed to not panic when this field is set. Signed-off-by: Peter Hunt <[email protected]>
openshift-ci
bot
added
the
approved
|
/payload |
|
@haircommander: it appears that you have attempted to use some version of the payload command, but your comment was incorrectly formatted and cannot be acted upon. See the docs for usage info. |
|
/payload 4.19 blocking |
|
/payload-aggregate periodic-ci-openshift-release-master-ci-4.19-e2e-azure-ovn-upgrade 10 |
|
@sohankunkerkar: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/40b85250-cc56-11ef-88f7-0f7917b80924-0 |
|
/retest |
|
/retitle OCPBUGS-45928: OCPBUGS-46531: crio: drop crun subcgroup |
openshift-ci
bot
changed the title
openshift-ci-robot
added
jira/valid-reference
|
@haircommander: This pull request references Jira Issue OCPBUGS-45928, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/jira refresh |
|
@sohankunkerkar: This pull request references Jira Issue OCPBUGS-45928, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/jira refresh |
openshift-ci-robot
added
jira/valid-bug
|
@sohankunkerkar: This pull request references Jira Issue OCPBUGS-45928, which is valid. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/payload 4.19 nightly blocking |
|
@sohankunkerkar: trigger 14 job(s) of type blocking for the nightly release of OCP 4.19
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/9f7e78c0-ccfe-11ef-8613-f6427d562f26-0 trigger 4 job(s) of type blocking for the ci release of OCP 4.19
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/9f7e78c0-ccfe-11ef-8613-f6427d562f26-1 |
openshift-ci
bot
added
the
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: haircommander, sohankunkerkar The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@stbenjam could you take a look at it? |
historically crun has run with a subcgroup to allow it to own the cgroup configuration of a container this is more idiomatic with systemd's single owner rule.
The problem is the subcgroup means there is an extra cgroup for cadvisor to read metrics for, so moving to crun by default actually increases cpu usage. Dropping the subcgroup (with a new cri-o knob and this annotation) fixes this regression.
This reverts commit 9e8ecf4, which was a revert of the original commit. CRI-O has now been fixed to not panic when this field is set.