Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add datavolume and datasource template for humans #1409

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

add datavolume and datasource template for humans #1409

wants to merge 1 commit into from
+31 −0

Conversation

weshayutin
Copy link
Contributor

Why the changes were made

a nice to have for humans manually testing virt
and oadp together.

How to test the changes made

  • install virt operator
cd  oadp-operator/tests/e2e/sample-applications/virtual-machines/cirros-test/
oc create namespace cirros-test
oc create -f cirros-ds.yaml
# check for complete
oc create -f cirros-test.yaml

@weshayutin
add datavolume and datasource template for humans
e351d4c 
a nice to have for humans manually testing virt
and oadp together.

Signed-off-by: Wesley Hayutin <[email protected]>
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Jun 3, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: weshayutin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 3, 2024
@weshayutin weshayutin added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. and removed approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jun 3, 2024
@weshayutin
Copy link
Contributor Author

still testing, hold

mateusoliveira43
mateusoliveira43 reviewed Jun 3, 2024
View reviewed changes
tests/e2e/sample-applications/virtual-machines/cirros-test/cirros-ds.yaml
cdi.kubevirt.io/storage.bind.immediate.requested: ""
cdi.kubevirt.io/storage.deleteAfterCompletion: "false"
name: cirros
namespace: cirros-test
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would make as equal to tests as possible. openshift-virtualization-os-images namespace is used there https://github.com/openshift/oadp-operator/blob/master/tests/e2e/virt_backup_restore_suite_test.go#L126

mateusoliveira43
mateusoliveira43 reviewed Jun 3, 2024
View reviewed changes
tests/e2e/sample-applications/virtual-machines/cirros-test/cirros-ds.yaml
storage: 128Mi
source:
http:
url: https://download.cirros-cloud.net/0.6.2/cirros-0.6.2-x86_64-disk.img
Copy link
Contributor

@mateusoliveira43 mateusoliveira43 Jun 3, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we pin a version and also use this file in tests?

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Jun 19, 2024

@weshayutin: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/4.12-e2e-test-aws e351d4c link true /test 4.12-e2e-test-aws
ci/prow/4.14-e2e-test-aws e351d4c link true /test 4.14-e2e-test-aws
ci/prow/4.13-e2e-test-aws e351d4c link true /test 4.13-e2e-test-aws
ci/prow/4.15-e2e-test-kubevirt-aws e351d4c link true /test 4.15-e2e-test-kubevirt-aws
ci/prow/4.15-e2e-test-aws e351d4c link true /test 4.15-e2e-test-aws
ci/prow/4.16-e2e-test-aws e351d4c link true /test 4.16-e2e-test-aws

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-bot
Copy link

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mateusoliveira43 mateusoliveira43 mateusoliveira43 left review comments

@eemcmullan eemcmullan Awaiting requested review from eemcmullan

@savitharaghunathan savitharaghunathan Awaiting requested review from savitharaghunathan

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@weshayutin @openshift-bot @mateusoliveira43