OADP-3050: Remove unwanted BSL/VSLs on create/edit DPA

[stillalearner]

Fixes the issue #1469 of unwanted BSL or VSLs in the cases:

1. BSLs/VSLs removed from DPA spec.
2. BSL/VSLs names modified in-place from DPA spec.
3. Default-named BSL/VSLs removed from DPA spec.

hope that covers all cases.

[openshift-ci-robot]

@stillalearner: This pull request references OADP-3050 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.18.0" version, but no target version was set.

In response to this:

Fixes the issue of unwanted BSL or VSLs in the cases:

1. BSLs/VSLs removed from DPA spec.
2. BSL/VSLs names modified in-place from DPA spec.
3. Default-named BSL/VSLs removed from DPA spec.

hope that covers all cases.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@stillalearner: This pull request references OADP-3050 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.18.0" version, but no target version was set.

In response to this:

Fixes the issue #1469 of unwanted BSL or VSLs in the cases:

1. BSLs/VSLs removed from DPA spec.
2. BSL/VSLs names modified in-place from DPA spec.
3. Default-named BSL/VSLs removed from DPA spec.

hope that covers all cases.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[kaovilai]

Have to double check but hopefully this doesn't break the workaround in
https://issues.redhat.com/browse/OADP-3630

[stillalearner]

Have to double check but hopefully this doesn't break the workaround in https://issues.redhat.com/browse/OADP-3630

I think it should not, as these changes only deal with the BSLs having all of the 3 labels.

While the workaround is only adding one of those. What do you think @kaovilai ?

[kaovilai]

While the workaround is only adding one of those. What do you think @kaovilai ?

works for me

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: stillalearner
Once this PR has been reviewed and has the lgtm label, please assign mrnold for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: stillalearner
Once this PR has been reviewed and has the lgtm label, please assign mrnold for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@stillalearner: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/4.15-e2e-test-aws	7aa3a88	link	true	/test 4.15-e2e-test-aws
ci/prow/4.16-e2e-test-aws	7aa3a88	link	true	/test 4.16-e2e-test-aws
ci/prow/4.14-e2e-test-aws	7aa3a88	link	true	/test 4.14-e2e-test-aws

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.