Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incremental backup support #81606

Merged
merged 1 commit into from
Sep 18, 2024
Merged

Incremental backup support #81606

merged 1 commit into from
Sep 18, 2024

Conversation

shdeshpa07
Copy link
Contributor

@shdeshpa07 shdeshpa07 commented Sep 11, 2024 •
edited
Loading

Jira

Added a note to express support for incremental backups

Version

  • OCP 4.13 → OCP 4.17

Preview

QE Review

  • QE has approved this change.

@shdeshpa07
Copy link
Contributor Author

/label OADP

@openshift-ci openshift-ci bot added OADP Label for all OADP PRs size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 11, 2024
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Sep 11, 2024 •
edited
Loading

🤖 Tue Sep 17 11:26:34 - Prow CI generated the docs preview:

https://81606--ocpdocs-pr.netlify.app/openshift-enterprise/latest/backup_and_restore/application_backup_and_restore/installing/about-oadp-1-3-data-mover.html
https://81606--ocpdocs-pr.netlify.app/openshift-enterprise/latest/backup_and_restore/application_backup_and_restore/installing/installing-oadp-kubevirt.html

@shdeshpa07
Copy link
Contributor Author

@anarnold97 - PR is ready for your review please. Thanks.

@weshayutin
Copy link

weshayutin commented Sep 11, 2024 •
edited
Loading

Sorry, @sseago reminded me we should add a note that volumeMode: Block volumes must use CSI DataMover backups, filesystem backups will not work and are not supported.

https://redhat-internal.slack.com/archives/C0144ECKUJ0/p1726060435885529

@shdeshpa07
Copy link
Contributor Author

Sorry, @sseago reminded me we should add a note that volumeMode: Block volumes must use CSI DataMover backups, filesystem backups will not work and are not supported.

https://redhat-internal.slack.com/archives/C0144ECKUJ0/p1726060435885529

@weshayutin - I have reworded the note based on your and Scott's review. Could you please review again? Thanks.

@shdeshpa07
Copy link
Contributor Author

@PrasadJoshi12 - Please review the PR. Thanks.

weshayutin
weshayutin approved these changes Sep 12, 2024
View reviewed changes
Copy link

@weshayutin weshayutin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM thank you!

@weshayutin
Copy link

weshayutin commented Sep 13, 2024 •
edited
Loading

OK.. I think the thread was lost along the way.. Here's our dev version of what we want to communicate to customers.
openshift/oadp-operator#1519
Hit us in office hours to discuss.

@shdeshpa07
Copy link
Contributor Author

OK.. I think the thread was lost along the way.. Here's our dev version of what we want to communicate to customers. openshift/oadp-operator#1519 Hit us in office hours to discuss.

Thank you Wes for the information. I will work on the changes and get back with the updated PR for review, Thanks.

@shdeshpa07 shdeshpa07 force-pushed the OADP-4820-Incremental-Backup-Support branch from 89675ff to f0d32b7 Compare September 16, 2024 12:08
@openshift-ci openshift-ci bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 16, 2024
@shdeshpa07
Copy link
Contributor Author

@weshayutin @PrasadJoshi12 - I have incorporated the feedback. Could you please review? Thanks.

weshayutin
weshayutin approved these changes Sep 16, 2024
View reviewed changes
Copy link

@weshayutin weshayutin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 16, 2024
@shdeshpa07 shdeshpa07 force-pushed the OADP-4820-Incremental-Backup-Support branch from 8c2f67c to 686310f Compare September 17, 2024 04:47
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Sep 17, 2024
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Sep 17, 2024

New changes are detected. LGTM label has been removed.

@shdeshpa07
Copy link
Contributor Author

/label peer-review-needed

@openshift-ci openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label Sep 17, 2024
@snarayan-redhat snarayan-redhat added peer-review-in-progress Signifies that the peer review team is reviewing this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Sep 17, 2024
snarayan-redhat
snarayan-redhat reviewed Sep 17, 2024
View reviewed changes
Copy link
Contributor

@snarayan-redhat snarayan-redhat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work :) !
Left a comment that you might want to fix.

modules/oadp-incremental-backup-support.adoc Outdated Show resolved Hide resolved
@snarayan-redhat snarayan-redhat removed the peer-review-in-progress Signifies that the peer review team is reviewing this PR label Sep 17, 2024
@snarayan-redhat snarayan-redhat added the peer-review-done Signifies that the peer review team has reviewed this PR label Sep 17, 2024
@shdeshpa07 shdeshpa07 force-pushed the OADP-4820-Incremental-Backup-Support branch from 565a08a to 28b4d62 Compare September 17, 2024 11:20
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Sep 17, 2024

@shdeshpa07: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@shdeshpa07
Copy link
Contributor Author

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Sep 18, 2024
@michaelryanpeter
Copy link
Contributor

/label merge-review-in-progress

@openshift-ci openshift-ci bot added the merge-review-in-progress Signifies that the merge review team is reviewing this PR label Sep 18, 2024
@michaelryanpeter michaelryanpeter added this to the Continuous Release milestone Sep 18, 2024
@michaelryanpeter michaelryanpeter merged commit 2f1112c into openshift:main Sep 18, 2024
2 checks passed
@michaelryanpeter
Copy link
Contributor

/cherrypick enterprise-4.17

@michaelryanpeter
Copy link
Contributor

/cherrypick enterprise-4.16

@michaelryanpeter
Copy link
Contributor

/cherrypick enterprise-4.15

@michaelryanpeter
Copy link
Contributor

/cherrypick enterprise-4.14

@michaelryanpeter
Copy link
Contributor

/cherrypick enterprise-4.13

@openshift-cherrypick-robot
Copy link

@michaelryanpeter: new pull request created: #82053

In response to this:

/cherrypick enterprise-4.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Sep 18, 2024
Merged
@openshift-cherrypick-robot
Copy link

@michaelryanpeter: new pull request created: #82054

In response to this:

/cherrypick enterprise-4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Sep 18, 2024
Merged
@openshift-cherrypick-robot
Copy link

@michaelryanpeter: new pull request created: #82055

In response to this:

/cherrypick enterprise-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Sep 18, 2024
Merged
@openshift-cherrypick-robot
Copy link

@michaelryanpeter: new pull request created: #82056

In response to this:

/cherrypick enterprise-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Sep 18, 2024
Merged
@openshift-cherrypick-robot
Copy link

@michaelryanpeter: new pull request created: #82057

In response to this:

/cherrypick enterprise-4.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Sep 18, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anarnold97 anarnold97 anarnold97 left review comments

@snarayan-redhat snarayan-redhat snarayan-redhat left review comments

@PrasadJoshi12 PrasadJoshi12 PrasadJoshi12 left review comments

@sseago sseago sseago approved these changes

@weshayutin weshayutin weshayutin approved these changes

Assignees

@weshayutin weshayutin

Labels
branch/enterprise-4.13 branch/enterprise-4.14 branch/enterprise-4.15 branch/enterprise-4.16 branch/enterprise-4.17 merge-review-in-progress Signifies that the merge review team is reviewing this PR merge-review-needed Signifies that the merge review team needs to review this PR OADP Label for all OADP PRs peer-review-done Signifies that the peer review team has reviewed this PR size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
Continuous Release
Development

Successfully merging this pull request may close these issues.
9 participants
@shdeshpa07 @ocpdocs-previewbot @weshayutin @michaelryanpeter @openshift-cherrypick-robot @sseago @PrasadJoshi12 @snarayan-redhat @anarnold97