Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OSD-22507: New IAM credential, secret rotate util #601

Open
wants to merge 13 commits into
base: master
Choose a base branch
from

Conversation

nephomaniac
Copy link

@nephomaniac nephomaniac commented Jul 23, 2024

First pass at OSD-22507. Attempting to consolidate previous bash, osdctl, additional SOP steps to into a single command/context to help users rotate Osd Admin user(s)' IAM creds and related secrets.

To test...
git clone [email protected]:nephomaniac/osdctl.git --branch OSD-22507-poc --single-branch --depth 1 osdctl_osd_22507 && cd osdctl_osd_22507

go build

./osdctl account iam-secret-mgmt -h

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 23, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jul 23, 2024

@nephomaniac: This pull request references OSD-22507 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.17.0" version, but no target version was set.

In response to this:

First pass at OSD-22507. Attempting to consolidate previous bash, osdctl, additional SOP steps to into a single command/context to help users rotate Osd Admin user(s)' IAM creds and related secrets.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from fahlmant and mjlshen July 23, 2024 20:56
@nephomaniac nephomaniac marked this pull request as draft July 24, 2024 19:47
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 24, 2024
Copy link
Contributor

@iamkirkbater iamkirkbater left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall this looks very good! Got a few comments, but I don't think any of them are MAJOR changes, like I mentioned at standup some of them are little nits or things like expanding on what something is with a comment because it doesn't make sense at first glance.

cmd/account/iam-cred-rotate.go Outdated Show resolved Hide resolved
cmd/account/iam-cred-rotate.go Outdated Show resolved Hide resolved
cmd/account/iam-cred-rotate.go Outdated Show resolved Hide resolved
cmd/account/iam-cred-rotate.go Outdated Show resolved Hide resolved
cmd/account/iam-cred-rotate.go Outdated Show resolved Hide resolved
cmd/account/iam-cred-rotate.go Show resolved Hide resolved
cmd/account/iam-cred-rotate.go Show resolved Hide resolved
cmd/account/iam-cred-rotate.go Show resolved Hide resolved
cmd/account/iam-cred-rotate.go Outdated Show resolved Hide resolved
cmd/account/iam-cred-rotate.go Outdated Show resolved Hide resolved
@nephomaniac
Copy link
Author

Big thanks @iamkirkbater for the review and comments. Most recent commit should contain these suggestions as well as support -o yaml/json to stdout (logs to stderr) for the 'describe' specific commands.

@nephomaniac nephomaniac marked this pull request as ready for review August 13, 2024 22:54
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 13, 2024
@openshift-ci openshift-ci bot requested a review from typeid August 13, 2024 22:54
@nephomaniac
Copy link
Author

/test lint

@nephomaniac nephomaniac changed the title OSD-22507: POC first pass at new rotate command (draft) OSD-22507: POC first pass at new rotate command Aug 30, 2024
Copy link
Member

@clcollins clcollins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally super small comments/spelling suggestions. I have one concern with saving the keys that might just be me being too paranoid, and a suggestion about how to search for the credentialsRequests.

Otherwise great work! This is WAY more than I expected it to be when I wrote OSD-22507!

cmd/account/iam-cred-rotate.go Show resolved Hide resolved
cmd/account/iam-cred-rotate.go Show resolved Hide resolved
cmd/account/iam-cred-rotate.go Show resolved Hide resolved
cmd/account/iam-cred-rotate.go Outdated Show resolved Hide resolved
cmd/account/iam-cred-rotate.go Show resolved Hide resolved
cmd/account/iam-cred-rotate.go Outdated Show resolved Hide resolved
cmd/account/iam-cred-rotate.go Outdated Show resolved Hide resolved
cmd/account/iam-cred-rotate.go Outdated Show resolved Hide resolved
cmd/account/iam-cred-rotate.go Outdated Show resolved Hide resolved
cmd/account/iam-cred-rotate.go Outdated Show resolved Hide resolved
@nephomaniac nephomaniac changed the title OSD-22507: POC first pass at new rotate command OSD-22507: New IAM credential, secret rotate util Sep 12, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 8, 2024

@nephomaniac: This pull request references OSD-22507 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

In response to this:

First pass at OSD-22507. Attempting to consolidate previous bash, osdctl, additional SOP steps to into a single command/context to help users rotate Osd Admin user(s)' IAM creds and related secrets.

To test...
git clone [email protected]:nephomaniac/osdctl.git --branch [OSD-22507](https://issues.redhat.com//browse/OSD-22507)-poc --single-branch --depth 1 osdctl_osd_22507 && cd osdctl_osd_22507 go build ./osdctl account iam-secret-mgmt -h

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

1 similar comment
@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 8, 2024

@nephomaniac: This pull request references OSD-22507 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

In response to this:

First pass at OSD-22507. Attempting to consolidate previous bash, osdctl, additional SOP steps to into a single command/context to help users rotate Osd Admin user(s)' IAM creds and related secrets.

To test...
git clone [email protected]:nephomaniac/osdctl.git --branch [OSD-22507](https://issues.redhat.com//browse/OSD-22507)-poc --single-branch --depth 1 osdctl_osd_22507 && cd osdctl_osd_22507 go build ./osdctl account iam-secret-mgmt -h

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 8, 2024

@nephomaniac: This pull request references OSD-22507 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

In response to this:

First pass at OSD-22507. Attempting to consolidate previous bash, osdctl, additional SOP steps to into a single command/context to help users rotate Osd Admin user(s)' IAM creds and related secrets.

To test...
`git clone [email protected]:nephomaniac/osdctl.git --branch OSD-22507-poc --single-branch --depth 1 osdctl_osd_22507 && cd osdctl_osd_22507

go build

./osdctl account iam-secret-mgmt -h`

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 8, 2024

@nephomaniac: This pull request references OSD-22507 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

In response to this:

First pass at OSD-22507. Attempting to consolidate previous bash, osdctl, additional SOP steps to into a single command/context to help users rotate Osd Admin user(s)' IAM creds and related secrets.

To test...
git clone [email protected]:nephomaniac/osdctl.git --branch OSD-22507-poc --single-branch --depth 1 osdctl_osd_22507 && cd osdctl_osd_22507

go build

./osdctl account iam-secret-mgmt -h

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link
Contributor

openshift-ci bot commented Oct 31, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: nephomaniac
Once this PR has been reviewed and has the lgtm label, please assign sam-nguyen7 for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@nephomaniac
Copy link
Author

/test lint

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 31, 2024
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 31, 2024
Copy link
Contributor

openshift-ci bot commented Oct 31, 2024

@nephomaniac: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants