Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test build images with different storage drivers #60174

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

zxiong
Copy link

@zxiong zxiong commented Dec 26, 2024

This PR is just for running perf test to compare buildah tasks with overlay and vfs storage driver (https://issues.redhat.com/browse/KONFLUX-363), it will be closed once the test finished.

@openshift-ci openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Dec 26, 2024
Copy link
Contributor

openshift-ci bot commented Dec 26, 2024

Hi @zxiong. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link
Contributor

openshift-ci bot commented Dec 26, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: zxiong
Once this PR has been reviewed and has the lgtm label, please assign pmacik for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot requested review from dheerajodha and psturc December 26, 2024 03:21
@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@zxiong: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-konflux-ci-e2e-tests-main-load-test-build-storage-driver-overlay konflux-ci/e2e-tests presubmit Presubmit changed
pull-ci-konflux-ci-e2e-tests-main-load-test-build-storage-driver-vfs konflux-ci/e2e-tests presubmit Presubmit changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@jinqi7
Copy link
Contributor

jinqi7 commented Dec 26, 2024

/ok-to-test

@openshift-ci openshift-ci bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 26, 2024
@zxiong
Copy link
Author

zxiong commented Dec 26, 2024

/pj-rehearse pull-ci-konflux-ci-e2e-tests-main-load-test-build-storage-driver-vfs

@openshift-ci-robot
Copy link
Contributor

@zxiong: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@zxiong
Copy link
Author

zxiong commented Dec 26, 2024

/pj-rehearse pull-ci-konflux-ci-e2e-tests-main-load-test-build-storage-driver-vfs

@openshift-ci-robot
Copy link
Contributor

@zxiong: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@jinqi7
Copy link
Contributor

jinqi7 commented Dec 30, 2024

@zxiong , is this PR ready to be merged?

@zxiong
Copy link
Author

zxiong commented Dec 30, 2024

@jinqi7 no, it's just for running tests. I will close it once tests completed.

@jinqi7
Copy link
Contributor

jinqi7 commented Dec 30, 2024

@jinqi7 no, it's just for running tests. I will close it once tests completed.

OK. It's better to add some description in the PR to avoid being merged.

Copy link
Contributor

openshift-ci bot commented Jan 10, 2025

@zxiong: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ok-to-test Indicates a non-member PR verified by an org member that is safe to test.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants