Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update code to fix wrong upgrade to version #60195

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Copy link
Contributor

openshift-ci bot commented Dec 27, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: liqcui
Once this PR has been reviewed and has the lgtm label, please assign paigerube14 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@liqcui: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
periodic-ci-openshift-qe-ocp-qe-perfscale-ci-main-rosa-4.15-candidate-x86-loaded-upgrade-from-4.14-loaded-upgrade415-24nodes N/A periodic Ci-operator config changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@liqcui
Copy link
Contributor Author

liqcui commented Dec 27, 2024

/pj-rehearse periodic-ci-openshift-qe-ocp-qe-perfscale-ci-main-rosa-4.15-candidate-x86-loaded-upgrade-from-4.14-loaded-upgrade415-24nodes

@openshift-ci-robot
Copy link
Contributor

@liqcui: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@liqcui
Copy link
Contributor Author

liqcui commented Dec 27, 2024

/cc @qiliRedHat

@openshift-ci openshift-ci bot requested a review from qiliRedHat December 27, 2024 08:28
@openshift-ci-robot
Copy link
Contributor

@liqcui: job(s): either don't exist or were not found to be affected, and cannot be rehearsed

@liqcui
Copy link
Contributor Author

liqcui commented Dec 27, 2024

/pj-rehearse periodic-ci-openshift-qe-ocp-qe-perfscale-ci-main-rosa-4.15-candidate-x86-loaded-upgrade-from-4.14-loaded-upgrade415-24nodes

@openshift-ci-robot
Copy link
Contributor

@liqcui: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@liqcui
Copy link
Contributor Author

liqcui commented Dec 27, 2024

/pj-rehearse periodic-ci-openshift-qe-ocp-qe-perfscale-ci-main-rosa-4.15-candidate-x86-loaded-upgrade-from-4.14-loaded-upgrade415-24nodes

@openshift-ci-robot
Copy link
Contributor

@liqcui: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

Copy link
Contributor

openshift-ci bot commented Dec 27, 2024

@liqcui: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/periodic-ci-openshift-qe-ocp-qe-perfscale-ci-main-rosa-4.15-candidate-x86-loaded-upgrade-from-4.14-loaded-upgrade415-24nodes 11e9a31 link unknown /pj-rehearse periodic-ci-openshift-qe-ocp-qe-perfscale-ci-main-rosa-4.15-candidate-x86-loaded-upgrade-from-4.14-loaded-upgrade415-24nodes

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants