Lowpass Filter Improved Uniform Sampling Check

[alexbeattie42]

Fixes issue #3968

Brief summary of changes

Implement an isUniform method to check if the vector is uniformly sampled. The implementation loosely follows the idea of the Matlab isUniform function. The implementation calculates the tolerance in this way:

isuniform verifies that the spacing between consecutive elements in numeric vector v does not deviate from the mean spacing by more than 4*eps(max(abs(v))), provided that the mean spacing is greater than that tolerance.

This may also fix this issue but I have not tested that myself yet.

Testing I've completed

Tested locally with this example and it fixes this issue. Will add unit tests soon.

Looking for feedback on...

@nickbianco and @aymanhab

• do you have feedback on this method for checking the uniform sampling
• where is the correct place for the uniform sampling check function to live. Maybe Signal?

CHANGELOG.md (choose one)

• Updated

---

This change is 

[nickbianco]

Nice work @alexbeattie42!

My main suggestion is to expose isUniform by adding it to CommonUtilities, with some documentation about how the uniformity checks work. You could then reference that in the updated documentation for TableUtilities::filterLowpass.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @alexbeattie42)

---

OpenSim/Common/TableUtilities.cpp line 126 at r1 (raw file):

template <typename T>
std::pair<bool,T> isUniform(const std::vector<T>& x) {

I think this would be a nice addition to CommonUtilities, as it might be useful for other table manipulation tools in OpenSim.

---

OpenSim/Common/TableUtilities.cpp line 189 at r1 (raw file):

    // Resample if the sampling interval is not uniform.
    if (!uniformlySampled) {

Could you add some documentation in the header file describing the conditions under which a table will be resampled?

[alexbeattie42]

@nickbianco could you take another look?

Reviewable status: 0 of 6 files reviewed, 2 unresolved discussions (waiting on @nickbianco)

---

OpenSim/Common/TableUtilities.cpp line 126 at r1 (raw file):

Previously, nickbianco (Nick Bianco) wrote…

I think this would be a nice addition to CommonUtilities, as it might be useful for other table manipulation tools in OpenSim.

Done.

---

OpenSim/Common/TableUtilities.cpp line 189 at r1 (raw file):

Previously, nickbianco (Nick Bianco) wrote…

Could you add some documentation in the header file describing the conditions under which a table will be resampled?

Done.