Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to stop control on system time jump #125

Merged
merged 3 commits into from
Apr 2, 2024

Conversation

at-wat
Copy link
Member

@at-wat at-wat commented Mar 28, 2024

Use yp-spur option added by openspur/yp-spur#191

@at-wat at-wat self-assigned this Mar 28, 2024
@at-wat

This comment has been minimized.

@at-wat at-wat requested a review from Taka-Kazu March 29, 2024 07:08
@at-wat
Copy link
Member Author

at-wat commented Apr 1, 2024

I'll update yp-spur version constraint once openspur/yp-spur#191 is merged and released

@at-wat

This comment has been minimized.

@@ -98,6 +98,7 @@ class YpspurRosNode
int key_;
bool simulate_;
bool wait_convergence_of_joint_trajectory_angle_vel_;
bool exit_on_time_jump_;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can be function local variable

@at-wat
Copy link
Member Author

at-wat commented Apr 2, 2024

[110] PASSED on noetic

All tests passed
build/test_results/ypspur_ros/roslint-ypspur_ros.xml: 1 tests
build/test_results/ypspur_ros/rostest-test_test_joint_trajectory.xml: 1 tests
build/test_results/ypspur_ros/rosunit-test_joint_trajectory.xml: 2 tests
Summary: 4 tests, 0 errors, 0 failures, 0 skipped

@at-wat at-wat merged commit ee35fe0 into master Apr 2, 2024
3 checks passed
@at-wat at-wat deleted the add-option-to-stop-control-on-system-time-jump branch April 2, 2024 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants