use post request for old advanced search #327
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…P/opensrp-client-child into 326-make-search-request-with-post
bump up code version
…P/opensrp-client-child into 326-make-search-request-with-post
PR NotesA security audit report recommended that since /fetch/search expects NFC Card Identifier as one of the parameters, the request should be made via POST which is relatively more secure |
qiarie
reviewed
Jan 26, 2023
| @@ -63,8 +64,12 @@ private Response<String> globalSearch(Map<String, String> searchParameters) { | |||
| if (ChildLibrary.getInstance().getProperties().isTrue(ChildAppProperties.KEY.USE_NEW_ADVANCE_SEARCH_APPROACH)) { | |||
| return retrieveRemoteClients(searchParameters); | |||
| } | |||
| String paramString = ""; | |||
| return searchUsingOldApproachWithPostRequest(searchParameters); | |||
There was a problem hiding this comment.
Could we update this method name to give more meaning?
| return searchUsingOldApproachWithPostRequest(searchParameters); | ||
| } | ||
|
|
||
| private Response<String> searchUsingOldApproachWithPostRequest(Map<String, String> searchParameters){ |
…P/opensrp-client-child into 326-make-search-request-with-post
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address #326