added the masked character support and Referenced field #663
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
junaidwarsivd
changed the title
ekigamba
suggested changes
Jun 26, 2023
| String referenceText = referenceField.getText().toString(); | ||
| return referenceText.equals(charSequence.toString()); | ||
| } | ||
| return true; |
There was a problem hiding this comment.
Should this return true?? What is the reference field has a some text and it not empty itself?
| private void addEqualsValidator(JsonFormFragment formFragment,JSONObject jsonObject, MaterialEditText editText) throws JSONException { | ||
| JSONObject requiredObject = jsonObject.optJSONObject(JsonFormConstants.V_EQUALS); | ||
| if (requiredObject != null) { | ||
| String referencedValue = requiredObject.optString(JsonFormConstants.VALUE,""); |
There was a problem hiding this comment.
- Check for empty string here
- Check for null in the line after this.
| String referencedValue = requiredObject.optString(JsonFormConstants.VALUE,""); | ||
| MaterialEditText referencedEditText = (MaterialEditText) formFragment.getJsonApi().getFormDataView(referencedValue); | ||
| editText.addValidator(new ReferenceFieldValidator(requiredObject.getString(JsonFormConstants.ERR),referencedEditText)); | ||
| FormUtils.setRequiredOnHint(editText); |
There was a problem hiding this comment.
Given that this is not a required field configuration, is FormUtils.setRequiredOnHint() supposed to be here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.