Remove unknown recipes when syncing #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The lp-build-config has to be the last word in recipes for the repos/LP projects that are managed as if a channel is moved from one branch to another the *old* recipe will still be maintained resulting in two recipes pushing to the same branch. This could lead to really weird conflicts. Thus, either charmed-openstack-info *is* the only metadata and controls the repos automatically, or we need to remove the auto-syncing. I'm in favour of the former, and so this change removes unknown (to charmed-openstack-info) recipes when merging a change to the repos.
freyes
approved these changes
Oct 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The lp-build-config has to be the last word in recipes for the repos/LP
projects that are managed as if a channel is moved from one branch to
another the old recipe will still be maintained resulting in two
recipes pushing to the same branch. This could lead to really weird
conflicts.
Thus, either charmed-openstack-info is the only metadata and controls
the repos automatically, or we need to remove the auto-syncing. I'm in
favour of the former, and so this change removes unknown (to
charmed-openstack-info) recipes when merging a change to the repos.