Added check for presence of systemd unit file before encryption #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SivolcC
force-pushed
the
check_systemd_files
branch
4 times, most recently
from
8f65641
to
35f90dc
Compare
SivolcC
force-pushed
the
check_systemd_files
branch
from
35f90dc
to
aba1074
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
This PR goal is to avoid eventual pitfalls in case Vaultlocker is installed in a virtualenv.
Indeed when installed this way, Vaultlocker won't have the
[email protected] systemdunit in neither/usr/lib/systemd/systemnor/etc/systemd/systemThis can be a problem, because if volumes are encrypted without this file present, they won't be decrypted automatically at boot (the user would have to manually run commands to do so).
In this PR, a check if performed before encrypting volumes. If the files are not found, a
FileNotFoundErrorexception is raised.Open to any remarks or questions.