Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DT - BMO deploy with preprovisioningNetworkData #413

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

DT - BMO deploy with preprovisioningNetworkData #413

wants to merge 1 commit into from
+4,642 −0

Conversation

hjensas
Copy link
Contributor

@hjensas hjensas commented Oct 4, 2024 •
edited
Loading

This DT ...

  • Uses OCP Metal3 to provision the compute nodes over redfish-virtualmedia.
  • Deploys the two pairs of compute nodes in separate networks - routed/spine-and-leaf architecture.

Depends-On: openstack-k8s-operators/ci-framework#2425

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Oct 4, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: hjensas
Once this PR has been reviewed and has the lgtm label, please assign abays for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@hjensas hjensas force-pushed the bmo01 branch 23 times, most recently from 6c57821 to ce91fbc Compare October 8, 2024 12:30
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

This change depends on a change that failed to merge.

Change openstack-k8s-operators/ci-framework#2425 is needed.

@hjensas hjensas force-pushed the bmo01 branch 10 times, most recently from 12ea488 to d72ab29 Compare October 10, 2024 08:13
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

This change depends on a change that failed to merge.

Change openstack-k8s-operators/ci-framework#2425 is needed.

abays
abays reviewed Oct 11, 2024
View reviewed changes
dt/bmo01/dataplane/baremetalhosts/baremetalhost_template.yaml Outdated
labels: {}
name: _ignored_
namespace: openstack
inspect.metal3.io: _replaced_
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
inspect.metal3.io: _replaced_
annotations:
inspect.metal3.io: _replaced_

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah, thanks!

Better now?
It "renders":

---
apiVersion: metal3.io/v1alpha1
kind: BareMetalHost
metadata:
  annotations:
    inspect.metal3.io: disabled
  labels:
    app: openstack

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, that looks good 👍

@hjensas hjensas force-pushed the bmo01 branch 3 times, most recently from f91d44d to c180dfa Compare October 15, 2024 07:56
hjensas added a commit to hjensas/ci-framework that referenced this pull request Oct 15, 2024
@hjensas
DT - BMO deploy with preprovisioningNetworkData
b37ac22 
This adds ci_gen_kustomize_values for the proposed `bmo01` deployment
topology in openstack-k8s-operators/architecture PR:
openstack-k8s-operators/architecture#413

This DT ...
* Uses OCP Metal3 to provision the compute nodes over redfish-virtualmedia.
* Deploys the two pairs of compute nodes in separate networks -
  routed/spine-and-leaf architecture.
@hjensas hjensas mentioned this pull request Oct 15, 2024
Merged
openshift-merge-bot bot pushed a commit to openstack-k8s-operators/ci-framework that referenced this pull request Oct 18, 2024
@hjensas @openshift-merge-bot
DT - BMO deploy with preprovisioningNetworkData
f9ba3da 
This adds ci_gen_kustomize_values for the proposed `bmo01` deployment
topology in openstack-k8s-operators/architecture PR:
openstack-k8s-operators/architecture#413

This DT ...
* Uses OCP Metal3 to provision the compute nodes over redfish-virtualmedia.
* Deploys the two pairs of compute nodes in separate networks -
  routed/spine-and-leaf architecture.
@hjensas hjensas force-pushed the bmo01 branch 7 times, most recently from e0d980e to 26aa0fc Compare October 24, 2024 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abays abays abays left review comments

@cjeanner cjeanner Awaiting requested review from cjeanner

@fultonj fultonj Awaiting requested review from fultonj

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hjensas @abays