Add gen-edpm-node-bootc.sh for creating bootc based nodes #931
Conversation
slagle
commented
Oct 16, 2024
slagle
commented
- Refactor common EDPM node code into gen-edpm-node-common.sh
- Add gen-edpm-node-bootc.sh for creating bootc based nodes
Allows the common bits of node creation to be used in different scripts. Signed-off-by: James Slagle <[email protected]>
|
Skipping CI for Draft Pull Request. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: slagle The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/e2b0070f6b30474f9bcbf250dd709477 ✔️ openstack-k8s-operators-content-provider SUCCESS in 3h 18m 36s |
Also adds a new Makefile target: make edpm_compute_bootc Depends on the image that will eventually be published at quay.io/openstack-k8s-operators/edpm-bootc:latest See openstack-k8s-operators/edpm-image-builder#37 Signed-off-by: James Slagle <[email protected]>
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/63a3d5b2bcf245a1b69e519d16f01220 ✔️ openstack-k8s-operators-content-provider SUCCESS in 4h 31m 51s |
| genisoimage -output ${EDPM_BOOTC_OUTPUT_DIR}/cidata.iso -V CIDATA -r -J ${EDPM_BOOTC_OUTPUT_DIR}/user-data ${EDPM_BOOTC_OUTPUT_DIR}/meta-data ${EDPM_BOOTC_OUTPUT_DIR}/network-config | ||
| fi | ||
|
|
||
| sudo podman run --rm -it --privileged \ |
There was a problem hiding this comment.
Any reason we can't just use the image built by edpm-image-builder? We can change the scripts to pass user-data/network-config with 'virt-install --cloud-init`(?) [1].
[1] https://github.com/virt-manager/virt-manager/blob/main/man/virt-install.rst#--cloud-init
There was a problem hiding this comment.
initially, i wanted to make use of the config.toml support as much as possible and that is something used during the build process. given how limited that interface is, I think we probably could just use the already built image and rely on cloud-init entirely instead.
