Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

People: add distinct mailing classification options to offices #120

Merged
merged 2 commits into from
Jan 24, 2024

Conversation

jessemortenson
Copy link
Contributor

Adds new classification options for an office: district-mail and capitol-mail.

Plural pulled in a new data source for People, that helps us add some data points that were not possible to scrape, and also still allows us to publish public data about elected officials.

This new dataset includes office addresses in some jurisdictions that are distinct between the physical location of the office and the mailing address. Adding these new classifications would allow us to have both data points in the People repo (otherwise those classifications are deemed invalid).

Possible downside: could move some data that was previously classified as district or capitol to one of the new classifications. Client code may not know how to handle these new classifications.

Alternative: leave the "mailing" addresses out of the People repo.

Copy link
Contributor

@NewAgeAirbender NewAgeAirbender left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's smart to add the data as distinct types

@chris-erickson
Copy link

chris-erickson commented Jan 24, 2024

For our purposes we check if the type is capitol or district and set that as a mailing address for each type. Sometimes we need to do some inference if that type isn't present based on if the city matches the Capitol city. I think to accommodate this new change we'd just check for this new attribute and use those addresses first, and fallback to the existing logic if not present. At a glance this doesn't look excessively complicated but any kind of advance notice of it happening or even just examples of the resulting data change as it relates to the API would be great.

I could see a case where we might store both so we can tell people where a physical office is more accurately, but that's not a very common use case for us.

@jessemortenson
Copy link
Contributor Author

Thanks for the feedback @chris-erickson - that's helpful. I'll merge this in, and then open up a couple PRs that show the data changes in a couple jurisdictions, will tag you in those.

@jessemortenson jessemortenson merged commit 5fcedfd into main Jan 24, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants