People: add distinct mailing classification options to offices #120
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds new classification options for an
office
:district-mail
andcapitol-mail
.Plural pulled in a new data source for People, that helps us add some data points that were not possible to scrape, and also still allows us to publish public data about elected officials.
This new dataset includes office addresses in some jurisdictions that are distinct between the physical location of the office and the mailing address. Adding these new classifications would allow us to have both data points in the People repo (otherwise those classifications are deemed invalid).
Possible downside: could move some data that was previously classified as
district
orcapitol
to one of the new classifications. Client code may not know how to handle these new classifications.Alternative: leave the "mailing" addresses out of the People repo.