Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add organization_classification to resolve_person context #140

Merged
merged 8 commits into from
Sep 16, 2024

Conversation

alexobaseki
Copy link
Contributor

@alexobaseki alexobaseki commented Aug 30, 2024

Also finding it difficult to get right jurisdiction to test this and ensure it is improving matching.

  • Some changes to to test, because we are now calling a lookup() that validates a jurisdiction ID in Event Importer so "jid" will fail test

@alexobaseki alexobaseki force-pushed the add-chamber-to-resolve-person branch from 0513390 to 2256024 Compare August 30, 2024 19:29
Copy link
Contributor

@jessemortenson jessemortenson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one note on typing

openstates/importers/events.py Outdated Show resolved Hide resolved
@alexobaseki alexobaseki marked this pull request as ready for review September 16, 2024 21:49
@alexobaseki alexobaseki merged commit a631f96 into main Sep 16, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants