Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve multiple people return resolve_person() #142

Merged
merged 3 commits into from
Sep 18, 2024
Merged

Improve multiple people return resolve_person() #142

merged 3 commits into from
Sep 18, 2024

Conversation

alexobaseki
Copy link
Contributor

We are trying to get a unique id when multiple ids are returned.

@alexobaseki alexobaseki marked this pull request as ready for review September 17, 2024 22:07
jessemortenson
jessemortenson approved these changes Sep 17, 2024
View reviewed changes
Copy link
Contributor

@jessemortenson jessemortenson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexobaseki alexobaseki merged commit ececf68 into main Sep 18, 2024
1 check passed
@alexobaseki alexobaseki deleted the improve-resolve-person branch September 18, 2024 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jessemortenson jessemortenson jessemortenson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexobaseki @jessemortenson