Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish openstate-core metadata #143

Merged
merged 15 commits into from
Oct 4, 2024
Merged

Conversation

alexobaseki
Copy link
Contributor

@alexobaseki alexobaseki commented Sep 20, 2024

The PR is attempting to create a separate package openstates_metadata so it can be used by external projects that rely on this data but not the entire openstates core project. There are a couple of motivation here;

  • Avoid installing the bigger project if we are just interested in use the metadata
  • Dependencies resolving can be a pain with a project like openstates core

@alexobaseki alexobaseki force-pushed the create-os-core-metadata-package branch from fcdcfd2 to 44718a8 Compare September 20, 2024 19:06
@alexobaseki alexobaseki marked this pull request as ready for review September 23, 2024 23:42
Copy link
Contributor

@jessemortenson jessemortenson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think a couple specific changes are needed, but I'll let you be the judge and overall LGTM on this approach

.github/workflows/release.yml Outdated Show resolved Hide resolved
.github/workflows/release.yml Outdated Show resolved Hide resolved
openstates/metadata/README.md.sample Outdated Show resolved Hide resolved
@alexobaseki alexobaseki merged commit 231506e into main Oct 4, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants