-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Left hand F-key dictionary #29
base: gh-pages
Are you sure you want to change the base?
Conversation
Shouldn't we just update the original left-hand modifiers dictionary? I never got around to it before. |
It would be possible to put all into one. I like to keep them apart here - easier to work with. ln the left-hand modifier dictionary, {#NOP} needs to be replaced by {#} to comply with recent Plover builds. |
…er file ({#} instead of {#NOP}.
The arrow keys should be left apart, though, since those use a different "theory". |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks so much @Achim63 for this PR. I'm so sorry I didn't reply for so long. I think it's a very clever dictionary. I've added some feedback, mainly only formatting changes in the readme!
I'd also like a clearer definition on why this is a separate dictionary from the Left Hand modifiers dictionary (I'm probably missing something obvious)
Thanks again for the request!
@@ -0,0 +1,86 @@ | |||
--- | |||
layout: dictionary | |||
title: Left hand modifier keys |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Title should be title case, and this is a macOS dictionary, so perhaps change this to:
Left Hand Modifier Keys, macOS
?
title: Left hand modifier keys | ||
version: 1 | ||
date: 2016-04-26 | ||
filename: lh_modifier_keys_osx.json |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know this PR is 5 months old, would it be possible to change osx
and OS X
to mac
and macOS
? It's just nitpicking though, it won't block this PR.
filename: lh_modifier_keys_osx.json | ||
author: Achim Siebert | ||
tags: commands shortcuts mac | ||
what: Common keyboard shortcuts for OSX, two-stroke left hand |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Again here it would be for macOS
- json | ||
--- | ||
|
||
## Why |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In Markdown it's style to add linebreaks around paragraphs. E.g.:
## Why
Paragraph content.
## How
Etc.
(`S`=Shift) + `KPWR`=Cmd + (`A`=Alt, `H`=Control) | ||
###**Special keys for the second stroke:** | ||
- `TPW` Tab | ||
- `SP ` Space |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Extra space here (SP
vs SP
)
Fire up menu shortcuts with your left hand only, so you can use the mouse at the same time. Easy to remember system for Cmd/Shift/Ctrl/Alt combinations together with letters, numbers, space, backspace, tab and escape. | ||
## How | ||
Strike one of the modifier briefs explained below, then the lefthand letter or binary(!) number that should be triggered with those modifiers. | ||
###**Examples:** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also style, I'd just leave this as ### Examples
as the heading should have the proper styling, and the colon shouldn't be necessary. If it's not bold enough, use ## Examples
.
###**Numbers for the second stroke:** | ||
Binary system from right to left using number bar and STPH | ||
- `#4`: 1 | ||
- `#3: 2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like here #3
doesn't have a closing code quote. The other problem is this bullet point has colons though the previous ones don't. I'd prefer either colons everywhere or nowhere.
No description provided.