This repository has been archived by the owner on Jun 18, 2024. It is now read-only.
feature/simple_prettier adds prettier and formats files #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmatejko
reviewed
Mar 3, 2022
Comment on lines
+85
to
+90
| if (center) | ||
| try { | ||
| center = JSON.parse(center); | ||
| } catch (e) { | ||
| console.warn(e); | ||
| } |
There was a problem hiding this comment.
it would be nice to have rule of mandatory {} brackets for every if statement because that's very hard to read and prone to issues now
Comment on lines
+1
to
+6
| { | ||
| "trailingComma": "es5", | ||
| "tabWidth": 4, | ||
| "semi": true, | ||
| "singleQuote": true | ||
| } |
There was a problem hiding this comment.
maybe it would be good to also have a prettier run on every commit?
https://prettier.io/docs/en/precommit.html
There was a problem hiding this comment.
We are moving project to React (take a look at https://github.com/openstreetmap-polska/ua-2022-map-v2) so it is pointless to configure it right there.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.