Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use dual stack (IPv4/IPv6) S3 endpoints for public-facing planet #632

Closed
wants to merge 2 commits into from
Closed

Use dual stack (IPv4/IPv6) S3 endpoints for public-facing planet #632

wants to merge 2 commits into from

Conversation

grischard
Copy link
Collaborator

@tomhughes
Copy link
Member

Does this also fix the other issue that @Firefishy was talking about with the bucket name?

@Firefishy
Copy link
Member

Does this also fix the other issue that @Firefishy was talking about with the bucket name?

I'm unsure what the issue was.

@Firefishy
Copy link
Member

Firefishy commented Oct 21, 2023 •
edited
Loading

@grischard I am not super eager for the double lookup, but unfortunately the dualstack URL doesn't support the short form I used.

If the 2 look ups somehow returned different results (not that I can see how), the result from AWS S3 is a IllegalLocationConstraintException error. The xxx location constraint is incompatible for the region specific endpoint this request was sent to.

@tomhughes
Copy link
Member

Oh sorry it was @pnorman that raised it not you...

@grischard
Copy link
Collaborator Author

@Firefishy removed double call in latest commit

@Firefishy
Copy link
Member

Firefishy commented Oct 21, 2023 •
edited
Loading

@Firefishy removed double call in latest commit

Yes that avoids the double call by making every request, even those not redirecting wait for a response from the lookup script. The lookups are serial and protected from concurrency by locks.

Realistically likely minimal impact.

@Firefishy
Copy link
Member

Replaced by #633

@Firefishy Firefishy closed this Oct 22, 2023
@Firefishy Firefishy deleted the s3-ipv4-ipv6-redirect branch November 20, 2023 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use dual stack S3 endpoints for public-facing planet
3 participants
@grischard @tomhughes @Firefishy