unbork cb76e3d: url filter in manager

openstyles · Sep 10, 2023 · c43acb8 · c43acb8
1 parent 7283df8
commit c43acb8
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 5 deletions.
diff --git a/manage/filters.js b/manage/filters.js
@@ -20,12 +20,14 @@ const fltModePref = 'manage.searchMode';
 let elSearch, elSearchMode;
 
 router.watch({search: [fltSearch, fltMode]}, ([search, mode]) => {
-  if (!elSearch) initFilters();
+  const firstRun = !elSearch;
+  if (firstRun) initFilters();
   elSearch.value = search || '';
   if (mode || elSearchMode.value === 'url') {
     elSearchMode.value = mode || prefs.get(fltModePref);
   }
-  searchStyles();
+  if (firstRun) filterOnChange({forceRefilter: true});
+  else searchStyles();
 });
 
 function initFilters() {
@@ -122,8 +124,6 @@ function initFilters() {
     filterOnChange({forceRefilter: true});
     router.updateSearch({[fltSearch]: '', [fltMode]: ''});
   };
-
-  filterOnChange({forceRefilter: true});
 }
 
 function filterOnChange({target: el, forceRefilter, alreadySearched}) {

diff --git a/manage/render.js b/manage/render.js
@@ -330,7 +330,18 @@ async function initBadFavs() {
       else el.append(opt);
     }
     el.value = value;
-    if (init) hideOpts.call(el);
+    if (init) {
+      const d = Object.getOwnPropertyDescriptor(Object.getPrototypeOf(el), 'value');
+      Object.defineProperty(el, 'value', {
+        get: () => d.get.call(el),
+        set: val => {
+          showOpts.call(el, {});
+          d.set.call(el, val);
+          el.dispatchEvent(new Event('input', {bubbles: true}));
+        },
+      });
+      hideOpts.call(el);
+    }
   };
 }