don't modify CM if new text is the same v2

openstyles · Aug 4, 2024 · f0457a0 · f0457a0
1 parent 819d61b
commit f0457a0
Showing 1 changed file with 8 additions and 10 deletions.
diff --git a/edit/moz-section-widget.js b/edit/moz-section-widget.js
@@ -81,7 +81,7 @@ function MozSectionWidget(cm, finder = MozSectionFinder(cm)) {
        */
       async '.add-applies-to'(elItem, func) {
         const pos = func.item.find(1);
-        cm.replaceRange(`, ${func._.type}("")`, pos, pos);
+        cm.replaceRange(`, ${func.str.type}("")`, pos, pos);
         await new Promise(setTimeout);
         $('input', elItem.nextElementSibling).focus();
       },
@@ -99,19 +99,17 @@ function MozSectionWidget(cm, finder = MozSectionFinder(cm)) {
         const func = getFuncFor(el);
         const pos = func[part].find();
         const {value} = el;
-        if (part === 'type' && value !== func._.type) {
-          func._.type = func.item[KEY].dataset.type = value;
+        if (value === func.str[part]) return;
+        func.str[part] = value;
+        if (part === 'type') {
+          func.item[KEY].dataset.type = value;
           editor.toggleRegexp(func.value[KEY], value);
-        }
-        if (part === 'value' && value === func._.value) {
-          return;
-        }
-        if (part === 'value' && func === getFuncsFor(el)[0]) {
+        } else if (func === getFuncsFor(el)[0]) {
           const sec = getSectionFor(el);
           sec.tocEntry.target = value;
           if (!sec.tocEntry.label) editor.updateToc([sec]);
         }
-        cm.replaceRange(toDoubleslash(value), pos.from, pos.to);
+        cm.replaceRange(toDoubleslash(value), pos.from, pos.to, finder.IGNORE_ORIGIN);
       },
       onclick(event) {
         const {target} = event;
@@ -364,7 +362,7 @@ function MozSectionWidget(cm, finder = MozSectionFinder(cm)) {
     const elVal = $(C_VALUE, el);
     /** @namespace MarkedFunc */
     const res = el[KEY] = {
-      _: func,
+      str: {type, value},
       item: markFuncPart(start, end, old.item, el),
       type: markFuncPart(start, typeEnd, old.type, $(C_TYPE, el), type, toLowerCase),
       value: markFuncPart(valuePos, valueEnd, old.value, elVal, value, fromDoubleslash),