Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add subtites and new text #13

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

lourieder
Copy link
Contributor

add some additional subtitles and new text to enhance usabilty of the instruction.
clarify the review and aproval process.

add some additional subtitles and new text to enhance usabilty of the instruction.
clarify the review and aproval process.
fix some RST Syntax errors
Copy link
Collaborator

@gtema gtema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about naming it like "general contribution workflow". Often projects place infos like that into the "contribution" guide.
I would also leave a link to the sandbox project, stating that further detailed explanations are present there, OR (what I really prefer) that we move/copy content of sandbox readme with pictures over here. Sandbox should be treated as playground and not the place with further documentation.
Definitely writing: "you can play around and test the process on the sanbox project" would make sense for me.

doc/source/change_proposal_process.rst Show resolved Hide resolved
doc/source/change_proposal_process.rst Outdated Show resolved Hide resolved
doc/source/change_proposal_process.rst Outdated Show resolved Hide resolved
doc/source/change_proposal_process.rst Show resolved Hide resolved
doc/source/change_proposal_process.rst Show resolved Hide resolved
doc/source/change_proposal_process.rst Outdated Show resolved Hide resolved
doc/source/change_proposal_process.rst Show resolved Hide resolved
doc/source/change_proposal_process.rst Show resolved Hide resolved
doc/source/change_proposal_process.rst Outdated Show resolved Hide resolved
@lourieder lourieder requested a review from gtema February 18, 2022 14:29
doc/source/change_proposal_process.rst Outdated Show resolved Hide resolved
doc/source/change_proposal_process.rst Show resolved Hide resolved
fix request made by
Copy link
Contributor Author

@lourieder lourieder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix all requests. please rereview

@lourieder
Copy link
Contributor Author

I´m not sure if there are more requested changes.

What about naming it like "general contribution workflow". Often projects place infos like that into the "contribution" guide. I would also leave a link to the sandbox project, stating that further detailed explanations are present there, OR (what I really prefer) that we move/copy content of sandbox readme with pictures over here. Sandbox should be treated as playground and not the place with further documentation. Definitely writing: "you can play around and test the process on the sanbox project" would make sense for me.

To this comment I can say: I agree with you but I´m not sure if I cloud do that alone. regardless of my ability to implement this request I would like to open a new commit+PR for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants