-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add subtites and new text #13
base: main
Are you sure you want to change the base?
Conversation
add some additional subtitles and new text to enhance usabilty of the instruction. clarify the review and aproval process.
fix some RST Syntax errors
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about naming it like "general contribution workflow". Often projects place infos like that into the "contribution" guide.
I would also leave a link to the sandbox project, stating that further detailed explanations are present there, OR (what I really prefer) that we move/copy content of sandbox readme with pictures over here. Sandbox should be treated as playground and not the place with further documentation.
Definitely writing: "you can play around and test the process on the sanbox project" would make sense for me.
fix request made by
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fix all requests. please rereview
I´m not sure if there are more requested changes.
To this comment I can say: I agree with you but I´m not sure if I cloud do that alone. regardless of my ability to implement this request I would like to open a new commit+PR for this. |
add some additional subtitles and new text to enhance usabilty of the instruction.
clarify the review and aproval process.