-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Code coverage suite (rebased #848 with workspace restructure) #1008
Draft
ales-otf
wants to merge
54
commits into
devnet-ready
Choose a base branch
from
chore/restructure-linting
base: devnet-ready
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ales-otf
force-pushed
the
chore/restructure-linting
branch
from
November 22, 2024 17:18
ce32fa4
to
c02a586
Compare
sam0x17
previously approved these changes
Nov 22, 2024
CI failing btw |
ales-otf
force-pushed
the
chore/restructure-linting
branch
from
November 25, 2024 20:58
30d46c5
to
7fbfe18
Compare
ales-otf
changed the title
Restructure workspace
Code coverage suite (rebased #848 with workspace restructure)
Nov 25, 2024
yeah, it's not ready yet. I'm toggling it into draft. |
ales-otf
added
blue team
defensive programming, CI, etc
no-spec-version-bump
PR does not contain changes that requires bumping the spec version
labels
Nov 25, 2024
ales-otf
force-pushed
the
chore/restructure-linting
branch
5 times, most recently
from
December 2, 2024 17:39
4062675
to
2ed4acc
Compare
ales-otf
force-pushed
the
chore/restructure-linting
branch
from
December 3, 2024 19:14
ef87c63
to
c7fd659
Compare
Depends on PR #977 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
blue team
defensive programming, CI, etc
no-spec-version-bump
PR does not contain changes that requires bumping the spec version
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds code coverage suite to the repo
#[import_section(..)]
/#[pallet_section]
build.rs
build-print
crate)RUN_COVERAGE
env var is present (from withinbuild.rs
)This PR also restructures the workspace by removing the root library and encapsulating logic from the root's
build.rs
intolinting
crate API. It addsbuild.rs
scripts to run the lints independently for each crate.The
code-coverage
is a binary, which you run using:The default crate in workspace is configured to be
node-subtensor
, so all commands go to this crate, if you don't pass-p <name>
argument. It allowscargo run
node, without specifying the package name.Future work:
Related Issue(s)
Type of Change
Checklist
cargo fmt
andcargo clippy
to ensure my code is formatted and linted correctly