Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/admin set evm chain #1030

Merged
merged 6 commits into from
Dec 6, 2024
Merged

Feat/admin set evm chain #1030

merged 6 commits into from
Dec 6, 2024

Conversation

gztensor
Copy link
Contributor

Description

Set the EVM pallet to use pallet-evm-chain-id for ChainID and add admin extrinsic to set the ChainID in pallet-evm-chain-id.

Related Issue(s)

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Other (please describe):

Breaking Change

n/a

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have run cargo fmt and cargo clippy to ensure my code is formatted and linted correctly
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Screenshots (if applicable)

n/a

Additional Notes

n/a

@gztensor gztensor linked an issue Nov 27, 2024 that may be closed by this pull request
@gztensor gztensor marked this pull request as ready for review November 27, 2024 20:42
@gztensor gztensor requested a review from unconst as a code owner November 27, 2024 20:42
camfairchild
camfairchild previously approved these changes Nov 27, 2024
@gztensor gztensor requested a review from sam0x17 December 3, 2024 17:44
sam0x17
sam0x17 previously approved these changes Dec 3, 2024
@sam0x17
Copy link
Contributor

sam0x17 commented Dec 3, 2024

just a few merge conflicts but otherwise looks good

@gztensor gztensor dismissed stale reviews from sam0x17 and camfairchild via 01e90ab December 3, 2024 23:02
camfairchild
camfairchild previously approved these changes Dec 3, 2024
@gztensor gztensor added the no-spec-version-bump PR does not contain changes that requires bumping the spec version label Dec 4, 2024
This reverts commit e9fb1c5.
@gztensor gztensor added the skip-cargo-audit This PR fails cargo audit but needs to be merged anyway label Dec 4, 2024
@sam0x17 sam0x17 merged commit f87d97d into devnet-ready Dec 6, 2024
19 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-spec-version-bump PR does not contain changes that requires bumping the spec version skip-cargo-audit This PR fails cargo audit but needs to be merged anyway
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[EVM] Add admin pallet extrinsic to set EVM Chain ID
3 participants