Feat/check metadata hash extension #684
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Upgrades to polkadot-sdk v1.10.0-rc3 which supports
frame_metadata_hash_extension::CheckMetadataHash
, required for Zondax's generic-substrate Ledger app.Related Issue(s)
Type of Change
Breaking Change
This PR introduces the Check Metadata Hash runtime extension which adds an extra
Mode
bit to all extrinsics.This indicates whether the chain node should verify the runtime hash provided in the extrinsic (used for secure signing). Therefore, this change breaks any current wallet clients that don't already support the extra bit (e.g. btcli).
New minimum PySubstrate version: https://github.com/polkascan/py-substrate-interface/releases/tag/v1.7.9
Implemented in: opentensor/bittensor#2156
Checklist
cargo fmt
andcargo clippy
to ensure my code is formatted and linted correctly