Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only run spec version check when the skip label doesn't exist #692

Merged
merged 4 commits into from
Aug 3, 2024
Merged

Only run spec version check when the skip label doesn't exist #692

merged 4 commits into from
Aug 3, 2024

Conversation

keithtensor
Copy link
Contributor

Fixes #673.

@keithtensor keithtensor requested a review from unconst as a code owner July 25, 2024 14:58
@keithtensor keithtensor added the no-spec-version-bump PR does not contain changes that requires bumping the spec version label Jul 25, 2024
camfairchild
camfairchild previously approved these changes Jul 30, 2024
View reviewed changes
@unconst unconst merged commit 88f6b57 into main Aug 3, 2024
11 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@open-junius open-junius open-junius approved these changes

@distributedstatemachine distributedstatemachine distributedstatemachine approved these changes

@sam0x17 sam0x17 sam0x17 approved these changes

@camfairchild camfairchild camfairchild left review comments

@unconst unconst Awaiting requested review from unconst unconst is a code owner

Assignees
No one assigned
Labels
no-spec-version-bump PR does not contain changes that requires bumping the spec version
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

allow skipping finney spec version check via a label
6 participants
@keithtensor @sam0x17 @camfairchild @distributedstatemachine @open-junius @unconst