fix storage item typos #834
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -780,7 +780,7 @@ pub mod pallet { | |||
| pub type HotkeyEmissionTempo<T> = | |||
| StorageValue<_, u64, ValueQuery, DefaultHotkeyEmissionTempo<T>>; | |||
| #[pallet::storage] | |||
| /// Map ( hot ) --> emission | Accumulated hotkey emission. | |||
| /// Name corrected: PendingdHotkeyEmission => PendingHotkeyEmission | |||
There was a problem hiding this comment.
Do we need this comment ?
There was a problem hiding this comment.
It's useful for people who index the chain like me. When I search the updated name there's nothing relevant, but the old name gives results:
- https://github.com/opentensor/subtensor/issues?q=is%3Aissue+PendingHotkeyEmission+
- https://github.com/opentensor/subtensor/issues?q=is%3Aissue+PendingdHotkeyEmission+
I happened to be aware of this typo, but if I wasn't and wanted to understand why my storage calls weren't working in earlier blocks this comment in the code would make it a lot easier to discover the reason.
| @@ -939,10 +949,14 @@ pub mod pallet { | |||
| pub type BlocksSinceLastStep<T> = | |||
| StorageMap<_, Identity, u16, u64, ValueQuery, DefaultBlocksSinceLastStep<T>>; | |||
| #[pallet::storage] | |||
| /// --- MAP ( netuid ) --> last_mechanism_step_block | |||
| /// Name corrected: LastMechansimStepBlock => LastMechanismStepBlock | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issue(s)
Type of Change
Breaking Change
renames storage items