Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return StakeWeight from NeuronInfoLite::stake #896

Closed
wants to merge 1 commit into from

Conversation

ales-otf
Copy link
Contributor

Description

It just fixes NeuronInfoLite::stake to return StakeWeight instead of Stake (why it must be StakeWeight has discussed here).

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Other (please describe):

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have run cargo fmt and cargo clippy to ensure my code is formatted and linted correctly
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@ales-otf ales-otf changed the base branch from main to feat/rao-devnet-ready October 31, 2024 16:49
@ales-otf ales-otf marked this pull request as ready for review October 31, 2024 16:49
@ales-otf ales-otf requested a review from unconst as a code owner October 31, 2024 16:49
@ales-otf ales-otf changed the title Fix/neuron info lite stake Return StakeWeight from NeuronInfoLite::stake Oct 31, 2024
@ales-otf ales-otf mentioned this pull request Oct 31, 2024
13 tasks
@ales-otf
Copy link
Contributor Author

ales-otf commented Nov 6, 2024

Blocked by #925

@ales-otf ales-otf marked this pull request as draft November 6, 2024 16:46
@ales-otf ales-otf force-pushed the fix/neuron-info-lite-stake branch from ab9239f to 1858438 Compare November 6, 2024 17:31
@ales-otf ales-otf marked this pull request as ready for review November 6, 2024 17:56
@ales-otf ales-otf marked this pull request as draft November 6, 2024 22:50
@ales-otf
Copy link
Contributor Author

ales-otf commented Nov 7, 2024

Merged by this

@ales-otf ales-otf closed this Nov 7, 2024
@ales-otf ales-otf linked an issue Nov 7, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inconsistent stake numbers across RPCs
3 participants